Commit 95c2d0ef authored Jan 07, 2019 by Wolfram Sang Committed by Geert Uytterhoeven Jan 21, 2019

pinctrl: sh-pfc: r8a7790: Initialize TDSEL register for ES1.0



Documentation for ES1.0 says that some bits in TDSEL must be set (ch
5.3.39 in R-Car H2 v0.91). However, the reset value of the register is
0, so software has to do it. Add this to the kernel driver to ensure
this is really done independent of firmware versions and use
whitelisting for ES versions known to need this.

This is needed for some SD cards supporting SDR104 transfer mode. For
me, TDSEL was not initialized by the firmware and I had problems with
the card when re-inserting it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

parent d2ccdc11

drivers/pinctrl/sh-pfc/pfc-r8a7790.c

+17 −0

Original line number	Diff line number	Diff line
		@@ -10,7 +10,9 @@

		#include <linux/io.h>
		#include <linux/kernel.h>
		#include <linux/sys_soc.h>

		#include "core.h"
		#include "sh_pfc.h"

		/*
		@@ -5691,7 +5693,22 @@ static int r8a7790_pin_to_pocctrl(struct sh_pfc pfc, unsigned int pin, u32 poc
		return 31 - (pin & 0x1f);
		}

		static const struct soc_device_attribute r8a7790_tdsel[] = {
		{ .soc_id = "r8a7790", .revision = "ES1.0" },
		{ /* sentinel */ }
		};

		static int r8a7790_pinmux_soc_init(struct sh_pfc *pfc)
		{
		/* Initialize TDSEL on old revisions */
		if (soc_device_match(r8a7790_tdsel))
		sh_pfc_write(pfc, 0xe6060088, 0x00155554);

		return 0;
		}

		static const struct sh_pfc_soc_operations r8a7790_pinmux_ops = {
		.init = r8a7790_pinmux_soc_init,
		.pin_to_pocctrl = r8a7790_pin_to_pocctrl,
		};

Admin message