Commit 957d1282 authored by Li Fei's avatar Li Fei Committed by Rafael J. Wysocki
Browse files

suspend: enable freeze timeout configuration through sys 



At present, the value of timeout for freezing is 20s, which is
meaningless in case that one thread is frozen with mutex locked
and another thread is trying to lock the mutex, as this time of
freezing will fail unavoidably.
And if there is no new wakeup event registered, the system will
waste at most 20s for such meaningless trying of freezing.

With this patch, the value of timeout can be configured to smaller
value, so such meaningless trying of freezing will be aborted in
earlier time, and later freezing can be also triggered in earlier
time. And more power will be saved.
In normal case on mobile phone, it costs real little time to freeze
processes. On some platform, it only costs about 20ms to freeze
user space processes and 10ms to freeze kernel freezable threads.

Signed-off-by: default avatarLiu Chuansheng <chuansheng.liu@intel.com>
Signed-off-by: default avatarLi Fei <fei.li@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 89a22dad

Documentation/power/freezing-of-tasks.txt

+5 −0
Original line number Diff line number Diff line
@@ -223,3 +223,8 @@ since they ask the freezer to skip freezing this task, since it is anyway 
only after the entire suspend/hibernation sequence is complete.

So, to summarize, use [un]lock_system_sleep() instead of directly using

mutex_[un]lock(&pm_mutex). That would prevent freezing failures.



V. Miscellaneous

/sys/power/pm_freeze_timeout controls how long it will cost at most to freeze

all user space processes or all freezable kernel threads, in unit of millisecond.

The default value is 20000, with range of unsigned integer.

include/linux/freezer.h

+5 −0
Original line number Diff line number Diff line
@@ -12,6 +12,11 @@ extern atomic_t system_freezing_cnt; /* nr of freezing conds in effect */ 
extern bool pm_freezing;		/* PM freezing in effect */

extern bool pm_nosig_freezing;		/* PM nosig freezing in effect */



/*

 * Timeout for stopping processes

 */

extern unsigned int freeze_timeout_msecs;



/*

 * Check if a process has been frozen

 */

kernel/power/main.c

+27 −0
Original line number Diff line number Diff line
@@ -553,6 +553,30 @@ power_attr(pm_trace_dev_match); 


#endif /* CONFIG_PM_TRACE */



#ifdef CONFIG_FREEZER

static ssize_t pm_freeze_timeout_show(struct kobject *kobj,

				      struct kobj_attribute *attr, char *buf)

{

	return sprintf(buf, "%u\n", freeze_timeout_msecs);

}



static ssize_t pm_freeze_timeout_store(struct kobject *kobj,

				       struct kobj_attribute *attr,

				       const char *buf, size_t n)

{

	unsigned long val;



	if (kstrtoul(buf, 10, &val))

		return -EINVAL;



	freeze_timeout_msecs = val;

	return n;

}



power_attr(pm_freeze_timeout);



#endif	/* CONFIG_FREEZER*/



static struct attribute * g[] = {

	&state_attr.attr,

#ifdef CONFIG_PM_TRACE
@@ -575,6 +599,9 @@ static struct attribute * g[] = { 
#ifdef CONFIG_PM_SLEEP_DEBUG

	&pm_print_times_attr.attr,

#endif

#endif

#ifdef CONFIG_FREEZER

	&pm_freeze_timeout_attr.attr,

#endif

	NULL,

};

kernel/power/process.c

+2 −2
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ 
/* 

 * Timeout for stopping processes

 */

#define TIMEOUT	(20 * HZ)

unsigned int __read_mostly freeze_timeout_msecs = 20 * MSEC_PER_SEC;



static int try_to_freeze_tasks(bool user_only)

{
@@ -36,7 +36,7 @@ static int try_to_freeze_tasks(bool user_only) 


	do_gettimeofday(&start);



	end_time = jiffies + TIMEOUT;

	end_time = jiffies + msecs_to_jiffies(freeze_timeout_msecs);



	if (!user_only)

		freeze_workqueues_begin();

CRA Git | Maintained and supported by SUSTech CRA and CCSE