Commit 957ad016 authored Nov 21, 2008 by Vegard Nossum Committed by Ingo Molnar Nov 21, 2008

sched: update comment for move_task_off_dead_cpu

Impact: cleanup

This commit:

commit f7b4cddc
Author: Oleg Nesterov <oleg@tv-sign.ru>
Date:   Tue Oct 16 23:30:56 2007 -0700

    do CPU_DEAD migrating under read_lock(tasklist) instead of write_lock_irq(ta

    Currently move_task_off_dead_cpu() is called under
    write_lock_irq(tasklist).  This means it can't use task_lock() which is
    needed to improve migrating to take task's ->cpuset into account.

    Change the code to call move_task_off_dead_cpu() with irqs enabled, and
    change migrate_live_tasks() to use read_lock(tasklist).

...forgot to update the comment in front of move_task_off_dead_cpu.

Reference: http://lkml.org/lkml/2008/6/23/135



Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent fc02e90c

kernel/sched.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -6094,7 +6094,6 @@ static int __migrate_task_irq(struct task_struct *p, int src_cpu, int dest_cpu)

		/*
		* Figure out where task on dead CPU should go, use force if necessary.
		* NOTE: interrupts should be disabled by the caller
		*/
		static void move_task_off_dead_cpu(int dead_cpu, struct task_struct *p)
		{

Admin message