Commit 956fcfcd authored Jul 17, 2020 by YueHaibing Committed by Alexei Starovoitov Jul 21, 2020

tools/bpftool: Fix error handing in do_skeleton()



Fix pass 0 to PTR_ERR, also dump more err info using
libbpf_strerror.

Fixes: 5dc7a8b2 ("bpftool, selftests/bpf: Embed object file inside skeleton")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
Link: https://lore.kernel.org/bpf/20200717123059.29624-1-yuehaibing@huawei.com

parent da7a3506

tools/bpf/bpftool/gen.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -302,8 +302,11 @@ static int do_skeleton(int argc, char **argv)
		opts.object_name = obj_name;
		obj = bpf_object__open_mem(obj_data, file_sz, &opts);
		if (IS_ERR(obj)) {
		char err_buf[256];

		libbpf_strerror(PTR_ERR(obj), err_buf, sizeof(err_buf));
		p_err("failed to open BPF object file: %s", err_buf);
		obj = NULL;
		p_err("failed to open BPF object file: %ld", PTR_ERR(obj));
		goto out;
		}

Admin message