Commit 9562cf28 authored Dec 27, 2013 by Fengguang Wu Committed by Jozsef Kadlecsik Mar 06, 2014

netfilter: ipset: Add hash: fix coccinelle warnings



net/netfilter/ipset/ip_set_hash_netnet.c:115:8-9: WARNING: return of 0/1 in function 'hash_netnet4_data_list' with return type bool
/c/kernel-tests/src/cocci/net/netfilter/ipset/ip_set_hash_netnet.c:338:8-9: WARNING: return of 0/1 in function 'hash_netnet6_data_list' with return type bool

Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: coccinelle/misc/boolreturn.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>

parent 35f6e63a

net/netfilter/ipset/ip_set_hash_netnet.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -112,10 +112,10 @@ hash_netnet4_data_list(struct sk_buff *skb,
		(flags &&
		nla_put_net32(skb, IPSET_ATTR_CADT_FLAGS, htonl(flags))))
		goto nla_put_failure;
		return 0;
		return false;

		nla_put_failure:
		return 1;
		return true;
		}

		static inline void
		@@ -334,10 +334,10 @@ hash_netnet6_data_list(struct sk_buff *skb,
		(flags &&
		nla_put_net32(skb, IPSET_ATTR_CADT_FLAGS, htonl(flags))))
		goto nla_put_failure;
		return 0;
		return false;

		nla_put_failure:
		return 1;
		return true;
		}

		static inline void

Admin message