Commit 955ec4cb authored Jan 24, 2018 by David Ahern Committed by David S. Miller Jan 25, 2018

net/ipv6: Do not allow route add with a device that is down



IPv6 allows routes to be installed when the device is not up (admin up).
Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
there is no reason for IPv6 to allow it, so check the flags and deny if
device is admin down.

Signed-off-by: David Ahern <dsahern@gmail.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent bfd4b329

net/ipv6/route.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -2734,6 +2734,12 @@ static struct rt6_info ip6_route_info_create(struct fib6_config cfg,
		if (!dev)
		goto out;

		if (!(dev->flags & IFF_UP)) {
		NL_SET_ERR_MSG(extack, "Nexthop device is not up");
		err = -ENETDOWN;
		goto out;
		}

		if (!ipv6_addr_any(&cfg->fc_prefsrc)) {
		if (!ipv6_chk_addr(net, &cfg->fc_prefsrc, dev, 0)) {
		NL_SET_ERR_MSG(extack, "Invalid source address");

Admin message