Commit 955833cf authored by Dave Chinner's avatar Dave Chinner Committed by Alex Elder
Browse files

xfs: make the log ticket ID available outside the log infrastructure 



The ticket ID is needed to uniquely identify transactions when doing busy
extent matching. Delayed logging changes the lifecycle of busy extents with
respect to the transaction structure lifecycle. Hence we can no longer use
the transaction structure as a means of determining the owner of the busy
extent as it may be freed and reused while the busy extent is still active.

This commit provides the infrastructure to access the xlog_tid_t held in the
ticket from a transaction handle. This avoids the need for callers to peek
into the transaction and log structures to find this out.

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
parent 169a7b07

fs/xfs/xfs_log.c

+7 −0
Original line number Diff line number Diff line
@@ -3312,6 +3312,13 @@ xfs_log_ticket_get( 
	return ticket;

}



xlog_tid_t

xfs_log_get_trans_ident(

	struct xfs_trans	*tp)

{

	return tp->t_ticket->t_tid;

}



/*

 * Allocate and initialise a new log ticket.

 */

fs/xfs/xfs_log.h

+3 −1
Original line number Diff line number Diff line
@@ -19,7 +19,6 @@ 
#define __XFS_LOG_H__



/* get lsn fields */



#define CYCLE_LSN(lsn) ((uint)((lsn)>>32))

#define BLOCK_LSN(lsn) ((uint)(lsn))
@@ -134,6 +133,7 @@ struct xlog_in_core; 
struct xlog_ticket;

struct xfs_log_item;

struct xfs_item_ops;

struct xfs_trans;



void	xfs_log_item_init(struct xfs_mount	*mp,

			struct xfs_log_item	*item,
@@ -190,6 +190,8 @@ void xlog_iodone(struct xfs_buf *); 
struct xlog_ticket * xfs_log_ticket_get(struct xlog_ticket *ticket);

void	  xfs_log_ticket_put(struct xlog_ticket *ticket);



xlog_tid_t xfs_log_get_trans_ident(struct xfs_trans *tp);



#endif

fs/xfs/xfs_log_priv.h

+0 −2
Original line number Diff line number Diff line
@@ -152,8 +152,6 @@ static inline uint xlog_get_client_id(__be32 i) 
#define	XLOG_RECOVERY_NEEDED	0x4	/* log was recovered */

#define XLOG_IO_ERROR		0x8	/* log hit an I/O error, and being

					   shutdown */

typedef __uint32_t xlog_tid_t;





#ifdef __KERNEL__

/*

fs/xfs/xfs_types.h

+2 −0
Original line number Diff line number Diff line
@@ -75,6 +75,8 @@ typedef __uint32_t xfs_dahash_t; /* dir/attr hash value */ 


typedef __uint16_t	xfs_prid_t;	/* prid_t truncated to 16bits in XFS */



typedef __uint32_t	xlog_tid_t;	/* transaction ID type */



/*

 * These types are 64 bits on disk but are either 32 or 64 bits in memory.

 * Disk based types:

CRA Git | Maintained and supported by SUSTech CRA and CCSE