Commit 952f3b51 authored Dec 06, 2006 by Christoph Lameter Committed by Linus Torvalds Dec 07, 2006

[PATCH] GFP_THISNODE must not trigger global reclaim



The intent of GFP_THISNODE is to make sure that an allocation occurs on a
particular node.  If this is not possible then NULL needs to be returned so
that the caller can choose what to do next on its own (the slab allocator
depends on that).

However, GFP_THISNODE currently triggers reclaim before returning a failure
(GFP_THISNODE means GFP_NORETRY is set).  If we have over allocated a node
then we will currently do some reclaim before returning NULL.  The caller
may want memory from other nodes before reclaim should be triggered.  (If
the caller wants reclaim then he can directly use __GFP_THISNODE instead).

There is no flag to avoid reclaim in the page allocator and adding yet
another GFP_xx flag would be difficult given that we are out of available
flags.

So just compare and see if all bits for GFP_THISNODE (__GFP_THISNODE,
__GFP_NORETRY and __GFP_NOWARN) are set.  If so then we return NULL before
waking up kswapd.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 5bcd234d

mm/page_alloc.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -1151,6 +1151,17 @@ restart:
		if (page)
		goto got_pg;

		/*
		* GFP_THISNODE (meaning __GFP_THISNODE, __GFP_NORETRY and
		* __GFP_NOWARN set) should not cause reclaim since the subsystem
		* (f.e. slab) using GFP_THISNODE may choose to trigger reclaim
		* using a larger set of nodes after it has established that the
		* allowed per node queues are empty and that nodes are
		* over allocated.
		*/
		if (NUMA_BUILD && (gfp_mask & GFP_THISNODE) == GFP_THISNODE)
		goto nopage;

		for (z = zonelist->zones; *z; z++)
		wakeup_kswapd(*z, order);

Admin message