Commit 951e2736 authored Jun 08, 2020 by Michał Mirosław Committed by Takashi Iwai Jun 08, 2020

ALSA: pcm: disallow linking stream to itself



Prevent SNDRV_PCM_IOCTL_LINK linking stream to itself - the code
can't handle it. Fixed commit is not where bug was introduced, but
changes the context significantly.

Cc: stable@vger.kernel.org
Fixes: 0888c321 ("pcm_native: switch to fdget()/fdput()")
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Link: https://lore.kernel.org/r/89c4a2487609a0ed6af3ecf01cc972bdc59a7a2d.1591634956.git.mirq-linux@rere.qmqm.pl


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 88d8822d

sound/core/pcm_native.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -2176,6 +2176,12 @@ static int snd_pcm_link(struct snd_pcm_substream *substream, int fd)
		}
		pcm_file = f.file->private_data;
		substream1 = pcm_file->substream;

		if (substream == substream1) {
		res = -EINVAL;
		goto _badf;
		}

		group = kzalloc(sizeof(*group), GFP_KERNEL);
		if (!group) {
		res = -ENOMEM;

Admin message