Commit 951b62c1 authored Oct 05, 2007 by Matthew Wilcox Committed by James Bottomley Mar 07, 2008

[SCSI] advansys: Fix bug in AdvLoadMicrocode



buf[i] can be up to 0xfd, so doubling it and assigning the result to an
unsigned char truncates the value.  Just use an unsigned int instead;
it's only a temporary.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent ce4796d1

drivers/scsi/advansys.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6439,7 +6439,7 @@ static int AdvLoadMicrocode(AdvPortAddr iop_base, unsigned char *buf, int size,
		i += 2;
		len += 2;
		} else {
		unsigned char off = buf[i] * 2;
		unsigned int off = buf[i] * 2;
		unsigned short word = (buf[off + 1] << 8) \| buf[off];
		AdvWriteWordAutoIncLram(iop_base, word);
		len += 2;

Admin message