Commit 9513ea4f authored Mar 16, 2019 by Colin Ian King Committed by Jason Gunthorpe Mar 27, 2019

IB/iser: remove uninitialized variable len

The variable len is not being inintialized and the uninitialized value is
being returned. However, this return path is never reached because the
default case in the switch statement returns -ENOSYS. Clean up the code
by replacing the return -ENOSYS with a break for the default case and
returning -ENOSYS at the end of the function. This allows len to be
removed. Also remove redundant break that follows a return statement.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent e2a438bd

drivers/infiniband/ulp/iser/iscsi_iser.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -763,7 +763,6 @@ static int iscsi_iser_get_ep_param(struct iscsi_endpoint *ep,
		enum iscsi_param param, char *buf)
		{
		struct iser_conn *iser_conn = ep->dd_data;
		int len;

		switch (param) {
		case ISCSI_PARAM_CONN_PORT:
		@@ -774,12 +773,10 @@ static int iscsi_iser_get_ep_param(struct iscsi_endpoint *ep,
		return iscsi_conn_get_addr_param((struct sockaddr_storage *)
		&iser_conn->ib_conn.cma_id->route.addr.dst_addr,
		param, buf);
		break;
		default:
		return -ENOSYS;
		break;
		}

		return len;
		return -ENOSYS;
		}

		/**

Admin message