Commit 9502cdf0 authored Dec 21, 2018 by Kangjie Lu Committed by Mauro Carvalho Chehab Jan 16, 2019

media: mt312: fix a missing check of mt312 reset



mt312_reset() may fail. Although it is called in the end of
mt312_set_frontend(), we better check its status and return its error
code upstream instead of 0.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: Matthias Schwarzott <zzam@gentoo.org>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent c9b7d8f2

drivers/media/dvb-frontends/mt312.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -645,7 +645,9 @@ static int mt312_set_frontend(struct dvb_frontend *fe)
		if (ret < 0)
		return ret;

		mt312_reset(state, 0);
		ret = mt312_reset(state, 0);
		if (ret < 0)
		return ret;

		return 0;
		}

Admin message