Commit 94ffb030 authored Dec 12, 2018 by Gustavo A. R. Silva Committed by Takashi Iwai Dec 13, 2018

ALSA: pcm: Fix potential Spectre v1 vulnerability

stream is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

sound/core/pcm.c:140 snd_pcm_control_ioctl() warn: potential spectre issue 'pcm->streams' [r] (local cap)

Fix this by sanitizing stream before using it to index pcm->streams

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2



Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: stable@vger.kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 4aea96f4

sound/core/pcm.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -25,6 +25,7 @@
		#include <linux/time.h>
		#include <linux/mutex.h>
		#include <linux/device.h>
		#include <linux/nospec.h>
		#include <sound/core.h>
		#include <sound/minors.h>
		#include <sound/pcm.h>
		@@ -129,6 +130,7 @@ static int snd_pcm_control_ioctl(struct snd_card *card,
		return -EFAULT;
		if (stream < 0 \|\| stream > 1)
		return -EINVAL;
		stream = array_index_nospec(stream, 2);
		if (get_user(subdevice, &info->subdevice))
		return -EFAULT;
		mutex_lock(&register_mutex);

Admin message