Commit 94f91922 authored Apr 16, 2015 by Krzysztof Kozlowski Committed by Linus Torvalds Apr 17, 2015

drivers/rtc/rtc-s5m.c: allow usage on device type different than main MFD type



The RTC driver supports two flavors of S5M devices: S5M8767-like and
S2MPS14-like.

On S2MPS13 and S2MPS14 devices the RTC module is the same so we want to
re-use the existing support of S2MPS14.  However device type was passed
from parent MFD driver in platform data structure.  This way for the
S2MPS13 device the main MFD driver passed device type of 'S2MPS13X'.

Instead decouple detecting of device type between main MFD and RTC driver.
 This allows adding support for other S2MPS14 variations (like S2MPS11 and
S2MPS13) easily by adding to mfd/sec-core.c:

static const struct mfd_cell s2mps13_devs[] = {
	{ .name = "s2mps14-rtc", }
};

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f4ae9497

drivers/rtc/rtc-s5m.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -92,7 +92,7 @@ struct s5m_rtc_info {
		struct regmap *regmap;
		struct rtc_device *rtc_dev;
		int irq;
		int device_type;
		enum sec_device_type device_type;
		int rtc_24hr_mode;
		const struct s5m_rtc_reg_config *regs;
		};
		@@ -668,7 +668,7 @@ static int s5m_rtc_probe(struct platform_device *pdev)
		if (!info)
		return -ENOMEM;

		switch (pdata->device_type) {
		switch (platform_get_device_id(pdev)->driver_data) {
		case S2MPS14X:
		case S2MPS13X:
		regmap_cfg = &s2mps14_rtc_regmap_config;
		@@ -686,7 +686,9 @@ static int s5m_rtc_probe(struct platform_device *pdev)
		alarm_irq = S5M8767_IRQ_RTCA1;
		break;
		default:
		dev_err(&pdev->dev, "Device type is not supported by RTC driver\n");
		dev_err(&pdev->dev,
		"Device type %lu is not supported by RTC driver\n",
		platform_get_device_id(pdev)->driver_data);
		return -ENODEV;
		}

		@@ -706,7 +708,7 @@ static int s5m_rtc_probe(struct platform_device *pdev)

		info->dev = &pdev->dev;
		info->s5m87xx = s5m87xx;
		info->device_type = s5m87xx->device_type;
		info->device_type = platform_get_device_id(pdev)->driver_data;

		if (s5m87xx->irq_data) {
		info->irq = regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq);

Admin message