rbd: remove barriers from img_request_layered_{set,clear,test}() (94f4857f) · Commits · 戴 / test

IMG_REQ_LAYERED is set in rbd_img_request_create(), and tested and cleared in rbd_img_request_destroy() when the image request is about to be destroyed. The barriers are unnecessary. Signed-off-by:

Ilya Dryomov <idryomov@gmail.com>

drivers/block/rbd.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1366,18 +1366,15 @@ static void rbd_osd_submit(struct ceph_osd_request *osd_req)
		static void img_request_layered_set(struct rbd_img_request *img_request)
		{
		set_bit(IMG_REQ_LAYERED, &img_request->flags);
		smp_mb();
		}

		static void img_request_layered_clear(struct rbd_img_request *img_request)
		{
		clear_bit(IMG_REQ_LAYERED, &img_request->flags);
		smp_mb();
		}

		static bool img_request_layered_test(struct rbd_img_request *img_request)
		{
		smp_mb();
		return test_bit(IMG_REQ_LAYERED, &img_request->flags) != 0;
		}

Admin message