Commit 94f2f142 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace 

Pull user namespace and namespace infrastructure changes from Eric W Biederman:
 "This set of changes starts with a few small enhnacements to the user
  namespace.  reboot support, allowing more arbitrary mappings, and
  support for mounting devpts, ramfs, tmpfs, and mqueuefs as just the
  user namespace root.

  I do my best to document that if you care about limiting your
  unprivileged users that when you have the user namespace support
  enabled you will need to enable memory control groups.

  There is a minor bug fix to prevent overflowing the stack if someone
  creates way too many user namespaces.

  The bulk of the changes are a continuation of the kuid/kgid push down
  work through the filesystems.  These changes make using uids and gids
  typesafe which ensures that these filesystems are safe to use when
  multiple user namespaces are in use.  The filesystems converted for
  3.9 are ceph, 9p, afs, ocfs2, gfs2, ncpfs, nfs, nfsd, and cifs.  The
  changes for these filesystems were a little more involved so I split
  the changes into smaller hopefully obviously correct changes.

  XFS is the only filesystem that remains.  I was hoping I could get
  that in this release so that user namespace support would be enabled
  with an allyesconfig or an allmodconfig but it looks like the xfs
  changes need another couple of days before it they are ready."

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace: (93 commits)
  cifs: Enable building with user namespaces enabled.
  cifs: Convert struct cifs_ses to use a kuid_t and a kgid_t
  cifs: Convert struct cifs_sb_info to use kuids and kgids
  cifs: Modify struct smb_vol to use kuids and kgids
  cifs: Convert struct cifsFileInfo to use a kuid
  cifs: Convert struct cifs_fattr to use kuid and kgids
  cifs: Convert struct tcon_link to use a kuid.
  cifs: Modify struct cifs_unix_set_info_args to hold a kuid_t and a kgid_t
  cifs: Convert from a kuid before printing current_fsuid
  cifs: Use kuids and kgids SID to uid/gid mapping
  cifs: Pass GLOBAL_ROOT_UID and GLOBAL_ROOT_GID to keyring_alloc
  cifs: Use BUILD_BUG_ON to validate uids and gids are the same size
  cifs: Override unmappable incoming uids and gids
  nfsd: Enable building with user namespaces enabled.
  nfsd: Properly compare and initialize kuids and kgids
  nfsd: Store ex_anon_uid and ex_anon_gid as kuids and kgids
  nfsd: Modify nfsd4_cb_sec to use kuids and kgids
  nfsd: Handle kuids and kgids in the nfs4acl to posix_acl conversion
  nfsd: Convert nfsxdr to use kuids and kgids
  nfsd: Convert nfs3xdr to use kuids and kgids
  ...
parents 8d168f71 139321c6

Documentation/namespaces/resource-control.txt

0 → 100644
+14 −0
Original line number Diff line number Diff line 
There are a lot of kinds of objects in the kernel that don't have

individual limits or that have limits that are ineffective when a set

of processes is allowed to switch user ids.  With user namespaces

enabled in a kernel for people who don't trust their users or their

users programs to play nice this problems becomes more acute.



Therefore it is recommended that memory control groups be enabled in

kernels that enable user namespaces, and it is further recommended

that userspace configure memory control groups to limit how much

memory user's they don't trust to play nice can use.



Memory control groups can be configured by installing the libcgroup

package present on most distros editing /etc/cgrules.conf,

/etc/cgconfig.conf and setting up libpam-cgroup.

fs/9p/fid.c

+9 −8
Original line number Diff line number Diff line
@@ -74,19 +74,20 @@ int v9fs_fid_add(struct dentry *dentry, struct p9_fid *fid) 
 *

 */



static struct p9_fid *v9fs_fid_find(struct dentry *dentry, u32 uid, int any)

static struct p9_fid *v9fs_fid_find(struct dentry *dentry, kuid_t uid, int any)

{

	struct v9fs_dentry *dent;

	struct p9_fid *fid, *ret;



	p9_debug(P9_DEBUG_VFS, " dentry: %s (%p) uid %d any %d\n",

		 dentry->d_name.name, dentry, uid, any);

		 dentry->d_name.name, dentry, from_kuid(&init_user_ns, uid),

		 any);

	dent = (struct v9fs_dentry *) dentry->d_fsdata;

	ret = NULL;

	if (dent) {

		spin_lock(&dent->lock);

		list_for_each_entry(fid, &dent->fidlist, dlist) {

			if (any || fid->uid == uid) {

			if (any || uid_eq(fid->uid, uid)) {

				ret = fid;

				break;

			}
@@ -126,7 +127,7 @@ err_out: 
}



static struct p9_fid *v9fs_fid_lookup_with_uid(struct dentry *dentry,

					       uid_t uid, int any)

					       kuid_t uid, int any)

{

	struct dentry *ds;

	char **wnames, *uname;
@@ -233,7 +234,7 @@ err_out: 


struct p9_fid *v9fs_fid_lookup(struct dentry *dentry)

{

	uid_t uid;

	kuid_t uid;

	int  any, access;

	struct v9fs_session_info *v9ses;
@@ -253,7 +254,7 @@ struct p9_fid *v9fs_fid_lookup(struct dentry *dentry) 
		break;



	default:

		uid = ~0;

		uid = INVALID_UID;

		any = 0;

		break;

	}
@@ -272,7 +273,7 @@ struct p9_fid *v9fs_fid_clone(struct dentry *dentry) 
	return ret;

}



static struct p9_fid *v9fs_fid_clone_with_uid(struct dentry *dentry, uid_t uid)

static struct p9_fid *v9fs_fid_clone_with_uid(struct dentry *dentry, kuid_t uid)

{

	struct p9_fid *fid, *ret;
@@ -289,7 +290,7 @@ struct p9_fid *v9fs_writeback_fid(struct dentry *dentry) 
	int err;

	struct p9_fid *fid;



	fid = v9fs_fid_clone_with_uid(dentry, 0);

	fid = v9fs_fid_clone_with_uid(dentry, GLOBAL_ROOT_UID);

	if (IS_ERR(fid))

		goto error_out;

	/*

fs/9p/v9fs.c

+27 −7
Original line number Diff line number Diff line
@@ -161,7 +161,13 @@ static int v9fs_parse_options(struct v9fs_session_info *v9ses, char *opts) 
				ret = r;

				continue;

			}

			v9ses->dfltuid = option;

			v9ses->dfltuid = make_kuid(current_user_ns(), option);

			if (!uid_valid(v9ses->dfltuid)) {

				p9_debug(P9_DEBUG_ERROR,

					 "uid field, but not a uid?\n");

				ret = -EINVAL;

				continue;

			}

			break;

		case Opt_dfltgid:

			r = match_int(&args[0], &option);
@@ -171,7 +177,13 @@ static int v9fs_parse_options(struct v9fs_session_info *v9ses, char *opts) 
				ret = r;

				continue;

			}

			v9ses->dfltgid = option;

			v9ses->dfltgid = make_kgid(current_user_ns(), option);

			if (!gid_valid(v9ses->dfltgid)) {

				p9_debug(P9_DEBUG_ERROR,

					 "gid field, but not a gid?\n");

				ret = -EINVAL;

				continue;

			}

			break;

		case Opt_afid:

			r = match_int(&args[0], &option);
@@ -248,8 +260,9 @@ static int v9fs_parse_options(struct v9fs_session_info *v9ses, char *opts) 
			else if (strcmp(s, "client") == 0) {

				v9ses->flags |= V9FS_ACCESS_CLIENT;

			} else {

				uid_t uid;

				v9ses->flags |= V9FS_ACCESS_SINGLE;

				v9ses->uid = simple_strtoul(s, &e, 10);

				uid = simple_strtoul(s, &e, 10);

				if (*e != '\0') {

					ret = -EINVAL;

					pr_info("Unknown access argument %s\n",
@@ -257,6 +270,13 @@ static int v9fs_parse_options(struct v9fs_session_info *v9ses, char *opts) 
					kfree(s);

					goto free_and_return;

				}

				v9ses->uid = make_kuid(current_user_ns(), uid);

				if (!uid_valid(v9ses->uid)) {

					ret = -EINVAL;

					pr_info("Uknown uid %s\n", s);

					kfree(s);

					goto free_and_return;

				}

			}



			kfree(s);
@@ -319,7 +339,7 @@ struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, 
	list_add(&v9ses->slist, &v9fs_sessionlist);

	spin_unlock(&v9fs_sessionlist_lock);



	v9ses->uid = ~0;

	v9ses->uid = INVALID_UID;

	v9ses->dfltuid = V9FS_DEFUID;

	v9ses->dfltgid = V9FS_DEFGID;
@@ -364,7 +384,7 @@ struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, 


		v9ses->flags &= ~V9FS_ACCESS_MASK;

		v9ses->flags |= V9FS_ACCESS_ANY;

		v9ses->uid = ~0;

		v9ses->uid = INVALID_UID;

	}

	if (!v9fs_proto_dotl(v9ses) ||

		!((v9ses->flags & V9FS_ACCESS_MASK) == V9FS_ACCESS_CLIENT)) {
@@ -375,7 +395,7 @@ struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, 
		v9ses->flags &= ~V9FS_ACL_MASK;

	}



	fid = p9_client_attach(v9ses->clnt, NULL, v9ses->uname, ~0,

	fid = p9_client_attach(v9ses->clnt, NULL, v9ses->uname, INVALID_UID,

							v9ses->aname);

	if (IS_ERR(fid)) {

		retval = PTR_ERR(fid);
@@ -387,7 +407,7 @@ struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, 
	if ((v9ses->flags & V9FS_ACCESS_MASK) == V9FS_ACCESS_SINGLE)

		fid->uid = v9ses->uid;

	else

		fid->uid = ~0;

		fid->uid = INVALID_UID;



#ifdef CONFIG_9P_FSCACHE

	/* register the session for caching */

fs/9p/v9fs.h

+5 −5
Original line number Diff line number Diff line
@@ -109,9 +109,9 @@ struct v9fs_session_info { 
	char *uname;		/* user name to mount as */

	char *aname;		/* name of remote hierarchy being mounted */

	unsigned int maxdata;	/* max data for client interface */

	unsigned int dfltuid;	/* default uid/muid for legacy support */

	unsigned int dfltgid;	/* default gid for legacy support */

	u32 uid;		/* if ACCESS_SINGLE, the uid that has access */

	kuid_t dfltuid;		/* default uid/muid for legacy support */

	kgid_t dfltgid;		/* default gid for legacy support */

	kuid_t uid;		/* if ACCESS_SINGLE, the uid that has access */

	struct p9_client *clnt;	/* 9p client */

	struct list_head slist; /* list of sessions registered with v9fs */

	struct backing_dev_info bdi;
@@ -165,8 +165,8 @@ extern struct inode *v9fs_inode_from_fid_dotl(struct v9fs_session_info *v9ses, 
#define V9FS_PORT	564

#define V9FS_DEFUSER	"nobody"

#define V9FS_DEFANAME	""

#define V9FS_DEFUID	(-2)

#define V9FS_DEFGID	(-2)

#define V9FS_DEFUID	KUIDT_INIT(-2)

#define V9FS_DEFGID	KGIDT_INIT(-2)



static inline struct v9fs_session_info *v9fs_inode2v9ses(struct inode *inode)

{

fs/9p/vfs_inode.c

+3 −3
Original line number Diff line number Diff line
@@ -225,9 +225,9 @@ v9fs_blank_wstat(struct p9_wstat *wstat) 
	wstat->uid = NULL;

	wstat->gid = NULL;

	wstat->muid = NULL;

	wstat->n_uid = ~0;

	wstat->n_gid = ~0;

	wstat->n_muid = ~0;

	wstat->n_uid = INVALID_UID;

	wstat->n_gid = INVALID_GID;

	wstat->n_muid = INVALID_UID;

	wstat->extension = NULL;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE