Commit 94ef80a5 authored Aug 01, 2019 by Bart Van Assche Committed by Martin K. Petersen Aug 07, 2019

scsi: core: Complain if scsi_target_block() fails

If scsi_target_block() fails that can break the code that calls this
function. Hence complain loudly if scsi_target_block() fails.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 09addb1d

drivers/scsi/scsi_lib.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -2772,7 +2772,12 @@ static int scsi_internal_device_unblock(struct scsi_device *sdev,
		static void
		device_block(struct scsi_device sdev, void data)
		{
		scsi_internal_device_block(sdev);
		int ret;

		ret = scsi_internal_device_block(sdev);

		WARN_ONCE(ret, "scsi_internal_device_block(%s) failed: ret = %d\n",
		dev_name(&sdev->sdev_gendev), ret);
		}

		static int

Admin message