Commit 94ef7aee authored by Douglas Anderson's avatar Douglas Anderson Committed by Felipe Balbi
Browse files

usb: dwc2: host: Always add to the tail of queues 



The queues the the dwc2 host controller used are truly queues.  That
means FIFO or first in first out.

Unfortunately though the code was iterating through these queues
starting from the head, some places in the code was adding things to the
queue by adding at the head instead of the tail.  That means last in
first out.  Doh.

Go through and just always add to the tail.

Doing this makes things much happier when I've got:
* 7-port USB 2.0 Single-TT hub
* - Microsoft 2.4 GHz Transceiver v7.0 dongle
* - Jabra speakerphone playing music

Acked-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarKever Yang <kever.yang@rock-chips.com>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Tested-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarFelipe Balbi <balbi@kernel.org>
parent 16e80218

drivers/usb/dwc2/hcd.c

+6 −5
Original line number Diff line number Diff line
@@ -969,7 +969,8 @@ enum dwc2_transaction_type dwc2_hcd_select_transactions( 
		 * periodic assigned schedule

		 */

		qh_ptr = qh_ptr->next;

		list_move(&qh->qh_list_entry, &hsotg->periodic_sched_assigned);

		list_move_tail(&qh->qh_list_entry,

			       &hsotg->periodic_sched_assigned);

		ret_val = DWC2_TRANSACTION_PERIODIC;

	}
@@ -1002,7 +1003,7 @@ enum dwc2_transaction_type dwc2_hcd_select_transactions( 
		 * non-periodic active schedule

		 */

		qh_ptr = qh_ptr->next;

		list_move(&qh->qh_list_entry,

		list_move_tail(&qh->qh_list_entry,

			       &hsotg->non_periodic_sched_active);



		if (ret_val == DWC2_TRANSACTION_NONE)
@@ -1176,7 +1177,7 @@ static void dwc2_process_periodic_channels(struct dwc2_hsotg *hsotg) 
			 * Move the QH from the periodic assigned schedule to

			 * the periodic queued schedule

			 */

			list_move(&qh->qh_list_entry,

			list_move_tail(&qh->qh_list_entry,

				       &hsotg->periodic_sched_queued);



			/* done queuing high bandwidth */

drivers/usb/dwc2/hcd_ddma.c

+2 −2
Original line number Diff line number Diff line
@@ -1326,7 +1326,7 @@ void dwc2_hcd_complete_xfer_ddma(struct dwc2_hsotg *hsotg, 
			dwc2_hcd_qh_unlink(hsotg, qh);

		} else {

			/* Keep in assigned schedule to continue transfer */

			list_move(&qh->qh_list_entry,

			list_move_tail(&qh->qh_list_entry,

				       &hsotg->periodic_sched_assigned);

			/*

			 * If channel has been halted during giveback of urb

drivers/usb/dwc2/hcd_intr.c

+2 −2
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ static void dwc2_sof_intr(struct dwc2_hsotg *hsotg) 
			 * Move QH to the ready list to be executed next

			 * (micro)frame

			 */

			list_move(&qh->qh_list_entry,

			list_move_tail(&qh->qh_list_entry,

				  &hsotg->periodic_sched_ready);

	}

	tr_type = dwc2_hcd_select_transactions(hsotg);
@@ -802,7 +802,7 @@ static void dwc2_halt_channel(struct dwc2_hsotg *hsotg, 
			 * halt to be queued when the periodic schedule is

			 * processed.

			 */

			list_move(&chan->qh->qh_list_entry,

			list_move_tail(&chan->qh->qh_list_entry,

				  &hsotg->periodic_sched_assigned);



			/*

drivers/usb/dwc2/hcd_queue.c

+4 −2
Original line number Diff line number Diff line
@@ -732,9 +732,11 @@ void dwc2_hcd_qh_deactivate(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh, 
	     dwc2_frame_num_le(qh->sched_frame, frame_number)) ||

	    (hsotg->core_params->uframe_sched <= 0 &&

	     qh->sched_frame == frame_number))

		list_move(&qh->qh_list_entry, &hsotg->periodic_sched_ready);

		list_move_tail(&qh->qh_list_entry,

			       &hsotg->periodic_sched_ready);

	else

		list_move(&qh->qh_list_entry, &hsotg->periodic_sched_inactive);

		list_move_tail(&qh->qh_list_entry,

			       &hsotg->periodic_sched_inactive);

}



/**

CRA Git | Maintained and supported by SUSTech CRA and CCSE