Commit 94c95ba6 authored Jun 11, 2013 by Viresh Kumar Committed by Ingo Molnar Jun 19, 2013

sched: Remove WARN_ON(!sd) from init_sched_groups_power()

sd can't be NULL in init_sched_groups_power() and so checking it for NULL isn't
useful. In case it is required, then also we need to rearrange the code a bit as
we already accessed invalid pointer sd to get sg: sg = sd->groups.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/2bbe633cd74b431c05253a8ce61fdfd5066a531b.1370948150.git.viresh.kumar@linaro.org

Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent cd08e923

kernel/sched/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5400,7 +5400,7 @@ static void init_sched_groups_power(int cpu, struct sched_domain *sd)
		{
		struct sched_group *sg = sd->groups;

		WARN_ON(!sd \|\| !sg);
		WARN_ON(!sg);

		do {
		sg->group_weight = cpumask_weight(sched_group_cpus(sg));