Commit 94a99763 authored Sep 04, 2019 by Björn Töpel Committed by Daniel Borkmann Sep 05, 2019

xsk: avoid store-tearing when assigning queues



Use WRITE_ONCE when doing the store of tx, rx, fq, and cq, to avoid
potential store-tearing. These members are read outside of the control
mutex in the mmap implementation.

Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Fixes: 37b07693 ("xsk: add missing write- and data-dependency barrier")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent 310f4204

net/xdp/xsk.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -434,7 +434,7 @@ static int xsk_init_queue(u32 entries, struct xsk_queue **queue,

		/* Make sure queue is ready before it can be seen by others */
		smp_wmb();
		*queue = q;
		WRITE_ONCE(*queue, q);
		return 0;
		}

Admin message