Commit 94a72b3f authored Sep 06, 2019 by Nicolas Dichtel Committed by David S. Miller Sep 10, 2019

bridge/mdb: remove wrong use of NLM_F_MULTI



NLM_F_MULTI must be used only when a NLMSG_DONE message is sent at the end.
In fact, NLMSG_DONE is sent only at the end of a dump.

Libraries like libnl will wait forever for NLMSG_DONE.

Fixes: 949f1e39 ("bridge: mdb: notify on router port add and del")
CC: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c8dc5595

net/bridge/br_mdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -437,7 +437,7 @@ static int nlmsg_populate_rtr_fill(struct sk_buff *skb,
		struct nlmsghdr *nlh;
		struct nlattr *nest;

		nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), NLM_F_MULTI);
		nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), 0);
		if (!nlh)
		return -EMSGSIZE;

Admin message