Commit 94a504c2 authored Mar 09, 2012 by Grazvydas Ignotas Committed by Liam Girdwood Mar 12, 2012

ASoC: omap-mcbsp: fix snd_pcm_hw_rule_add arguments



We are setting SNDRV_PCM_HW_PARAM_BUFFER_SIZE based on
SNDRV_PCM_HW_PARAM_CHANNELS, not vice versa. This bug didn't
have much impact because the rules are evaluated multiple times
by the core, and intended value got set eventually.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@ti.com>

parent 5788c62e

sound/soc/omap/omap-mcbsp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -142,10 +142,10 @@ static int omap_mcbsp_dai_startup(struct snd_pcm_substream *substream,
		* smaller buffer than the FIFO size to avoid underruns
		*/
		snd_pcm_hw_rule_add(substream->runtime, 0,
		SNDRV_PCM_HW_PARAM_CHANNELS,
		SNDRV_PCM_HW_PARAM_BUFFER_SIZE,
		omap_mcbsp_hwrule_min_buffersize,
		mcbsp,
		SNDRV_PCM_HW_PARAM_BUFFER_SIZE, -1);
		SNDRV_PCM_HW_PARAM_CHANNELS, -1);

		/* Make sure, that the period size is always even */
		snd_pcm_hw_constraint_step(substream->runtime, 0,

Admin message