Commit 949f4a7c authored by Jan Kara's avatar Jan Kara
Browse files

udf: Protect all modifications of LVID with s_alloc_mutex 



udf_open_lvid() and udf_close_lvid() were modifying LVID without
s_alloc_mutex. Since they can be called from remount, the modification
could race with other filesystem modifications of LVID so protect them
by s_alloc_mutex just to be sure.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent d664b6af

fs/udf/super.c

+5 −0
Original line number Diff line number Diff line
@@ -1773,6 +1773,8 @@ static void udf_open_lvid(struct super_block *sb) 


	if (!bh)

		return;



	mutex_lock(&sbi->s_alloc_mutex);

	lvid = (struct logicalVolIntegrityDesc *)bh->b_data;

	lvidiu = udf_sb_lvidiu(sbi);
@@ -1789,6 +1791,7 @@ static void udf_open_lvid(struct super_block *sb) 
	lvid->descTag.tagChecksum = udf_tag_checksum(&lvid->descTag);

	mark_buffer_dirty(bh);

	sbi->s_lvid_dirty = 0;

	mutex_unlock(&sbi->s_alloc_mutex);

}



static void udf_close_lvid(struct super_block *sb)
@@ -1801,6 +1804,7 @@ static void udf_close_lvid(struct super_block *sb) 
	if (!bh)

		return;



	mutex_lock(&sbi->s_alloc_mutex);

	lvid = (struct logicalVolIntegrityDesc *)bh->b_data;

	lvidiu = udf_sb_lvidiu(sbi);

	lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
@@ -1821,6 +1825,7 @@ static void udf_close_lvid(struct super_block *sb) 
	lvid->descTag.tagChecksum = udf_tag_checksum(&lvid->descTag);

	mark_buffer_dirty(bh);

	sbi->s_lvid_dirty = 0;

	mutex_unlock(&sbi->s_alloc_mutex);

}



u64 lvid_get_unique_id(struct super_block *sb)

CRA Git | Maintained and supported by SUSTech CRA and CCSE