Commit 949c0336 authored Jul 11, 2017 by Gleb Fotengauer-Malinovskiy Committed by Radim Krčmář Jul 12, 2017

KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition

In case of KVM_S390_GET_CMMA_BITS, the kernel does not only read struct
kvm_s390_cmma_log passed from userspace (which constitutes _IOC_WRITE),
it also writes back a return value (which constitutes _IOC_READ) making
this an _IOWR ioctl instead of _IOW.

Fixes: 4036e387 ("KVM: s390: ioctls to get and set guest storage attributes")
Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

parent 48ae0fb4

include/uapi/linux/kvm.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -1351,7 +1351,7 @@ struct kvm_s390_ucas_mapping {
		/* Available with KVM_CAP_X86_SMM */
		#define KVM_SMI _IO(KVMIO, 0xb7)
		/* Available with KVM_CAP_S390_CMMA_MIGRATION */
		#define KVM_S390_GET_CMMA_BITS _IOW(KVMIO, 0xb8, struct kvm_s390_cmma_log)
		#define KVM_S390_GET_CMMA_BITS _IOWR(KVMIO, 0xb8, struct kvm_s390_cmma_log)
		#define KVM_S390_SET_CMMA_BITS _IOW(KVMIO, 0xb9, struct kvm_s390_cmma_log)

		#define KVM_DEV_ASSIGN_ENABLE_IOMMU (1 << 0)