timekeeping: Add a fast and NMI safe boot clock (948a5312) · Commits · 戴 / test

This boot clock can be used as a tracing clock and will account for suspend time. To keep it NMI safe since we're accessing from tracing, we're not using a separate timekeeper with updates to monotonic clock and boot offset protected with seqlocks. This has the following minor side effects: (1) Its possible that a timestamp be taken after the boot offset is updated but before the timekeeper is updated. If this happens, the new boot offset is added to the old timekeeping making the clock appear to update slightly earlier: CPU 0 CPU 1 timekeeping_inject_sleeptime64() __timekeeping_inject_sleeptime(tk, delta); timestamp(); timekeeping_update(tk, TK_CLEAR_NTP...); (2) On 32-bit systems, the 64-bit boot offset (tk->offs_boot) may be partially updated. Since the tk->offs_boot update is a rare event, this should be a rare occurrence which postprocessing should be able to handle. Signed-off-by:

Joel Fernandes <joelaf@google.com> Signed-off-by:

John Stultz <john.stultz@linaro.org> Reviewed-by:

Thomas Gleixner <tglx@linutronix.de> Cc: Prarit Bhargava <prarit@redhat.com> Cc: Richard Cochran <richardcochran@gmail.com> Cc: Steven Rostedt <rostedt@goodmis.org> Link: http://lkml.kernel.org/r/1480372524-15181-6-git-send-email-john.stultz@linaro.org Signed-off-by:

Thomas Gleixner <tglx@linutronix.de>

include/linux/timekeeping.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -249,6 +249,7 @@ static inline u64 ktime_get_raw_ns(void)

		extern u64 ktime_get_mono_fast_ns(void);
		extern u64 ktime_get_raw_fast_ns(void);
		extern u64 ktime_get_boot_fast_ns(void);

		/*
		* Timespec interfaces utilizing the ktime based ones

kernel/time/timekeeping.c

+29 −0

Original line number	Diff line number	Diff line
		@@ -425,6 +425,35 @@ u64 ktime_get_raw_fast_ns(void)
		}
		EXPORT_SYMBOL_GPL(ktime_get_raw_fast_ns);

		/**
		* ktime_get_boot_fast_ns - NMI safe and fast access to boot clock.
		*
		* To keep it NMI safe since we're accessing from tracing, we're not using a
		* separate timekeeper with updates to monotonic clock and boot offset
		* protected with seqlocks. This has the following minor side effects:
		*
		* (1) Its possible that a timestamp be taken after the boot offset is updated
		* but before the timekeeper is updated. If this happens, the new boot offset
		* is added to the old timekeeping making the clock appear to update slightly
		* earlier:
		* CPU 0 CPU 1
		* timekeeping_inject_sleeptime64()
		* __timekeeping_inject_sleeptime(tk, delta);
		* timestamp();
		* timekeeping_update(tk, TK_CLEAR_NTP...);
		*
		* (2) On 32-bit systems, the 64-bit boot offset (tk->offs_boot) may be
		* partially updated. Since the tk->offs_boot update is a rare event, this
		* should be a rare occurrence which postprocessing should be able to handle.
		*/
		u64 notrace ktime_get_boot_fast_ns(void)
		{
		struct timekeeper *tk = &tk_core.timekeeper;

		return (ktime_get_mono_fast_ns() + ktime_to_ns(tk->offs_boot));
		}
		EXPORT_SYMBOL_GPL(ktime_get_boot_fast_ns);

		/* Suspend-time cycles value for halted fast timekeeper. */
		static cycle_t cycles_at_suspend;

Admin message