Commit 94803aef authored Jan 28, 2019 by Paweł Chmiel Committed by Dmitry Torokhov Jan 28, 2019

Input: pwm-vibra - stop regulator after disabling pwm, not before



This patch fixes order of disable calls in pwm_vibrator_stop.
Currently when starting device, we first enable vcc regulator and then
setup and enable pwm. When stopping, we should do this in oposite order,
so first disable pwm and then disable regulator.
Previously order was the same as in start.

Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 3ca232df

drivers/input/misc/pwm-vibra.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -80,14 +80,14 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator)

		static void pwm_vibrator_stop(struct pwm_vibrator *vibrator)
		{
		if (vibrator->pwm_dir)
		pwm_disable(vibrator->pwm_dir);
		pwm_disable(vibrator->pwm);

		if (vibrator->vcc_on) {
		regulator_disable(vibrator->vcc);
		vibrator->vcc_on = false;
		}

		if (vibrator->pwm_dir)
		pwm_disable(vibrator->pwm_dir);
		pwm_disable(vibrator->pwm);
		}

		static void pwm_vibrator_play_work(struct work_struct *work)

Admin message