Commit 94801e5c authored by Linus Torvalds's avatar Linus Torvalds
Browse files
Pull pin control fixes from Linus Walleij:
 "Here is a late set of pin control fixes for v5.10, most concern some
  minor and major issues found in the Intel drivers. Some are so hairy
  that I have no idea what is going on there, but luckily the maintainer
  knows what's up.

  We also have an interesting fix for AMD, which makes AMD-based laptops
  more stable IIUC.

  Summary:

   - Fix up some SPI group and a register offset on Intel Jasperlake

   - Set default bias on Intel Merrifield

   - Preserve debouncing on Intel Baytrail

   - Stop .set_type() irqchip callback in the AMD driver from fiddling
     with the debounce filter

   - Fix access to GPIO banks that are pass-thru on the Aspeed

   - Fix a fix for the Intel pin control driver to disable Rx/Tx when
     requesting a UART line as GPIO"

* tag 'pinctrl-v5.10-3' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl:
  pinctrl: intel: Actually disable Tx and Rx buffers on GPIO request
  pinctrl: aspeed: Fix GPIO requests on pass-through banks
  pinctrl: amd: remove debounce filter setting in IRQ type setting
  pinctrl: baytrail: Avoid clearing debounce value when turning it off
  pinctrl: merrifield: Set default bias in case no particular value given
  pinctrl: jasperlake: Fix HOSTSW_OWN offset
  pinctrl: jasperlake: Unhide SPI group of pins
parents 6d47cdec e8873c0a
Loading
Loading
Loading
Loading
+68 −6
Original line number Diff line number Diff line
@@ -286,14 +286,76 @@ int aspeed_pinmux_set_mux(struct pinctrl_dev *pctldev, unsigned int function,
static bool aspeed_expr_is_gpio(const struct aspeed_sig_expr *expr)
{
	/*
	 * The signal type is GPIO if the signal name has "GPI" as a prefix.
	 * strncmp (rather than strcmp) is used to implement the prefix
	 * requirement.
	 * We need to differentiate between GPIO and non-GPIO signals to
	 * implement the gpio_request_enable() interface. For better or worse
	 * the ASPEED pinctrl driver uses the expression names to determine
	 * whether an expression will mux a pin for GPIO.
	 *
	 * expr->signal might look like "GPIOB1" in the GPIO case.
	 * expr->signal might look like "GPIT0" in the GPI case.
	 * Generally we have the following - A GPIO such as B1 has:
	 *
	 *    - expr->signal set to "GPIOB1"
	 *    - expr->function set to "GPIOB1"
	 *
	 * Using this fact we can determine whether the provided expression is
	 * a GPIO expression by testing the signal name for the string prefix
	 * "GPIO".
	 *
	 * However, some GPIOs are input-only, and the ASPEED datasheets name
	 * them differently. An input-only GPIO such as T0 has:
	 *
	 *    - expr->signal set to "GPIT0"
	 *    - expr->function set to "GPIT0"
	 *
	 * It's tempting to generalise the prefix test from "GPIO" to "GPI" to
	 * account for both GPIOs and GPIs, but in doing so we run aground on
	 * another feature:
	 *
	 * Some pins in the ASPEED BMC SoCs have a "pass-through" GPIO
	 * function where the input state of one pin is replicated as the
	 * output state of another (as if they were shorted together - a mux
	 * configuration that is typically enabled by hardware strapping).
	 * This feature allows the BMC to pass e.g. power button state through
	 * to the host while the BMC is yet to boot, but take control of the
	 * button state once the BMC has booted by muxing each pin as a
	 * separate, pin-specific GPIO.
	 *
	 * Conceptually this pass-through mode is a form of GPIO and is named
	 * as such in the datasheets, e.g. "GPID0". This naming similarity
	 * trips us up with the simple GPI-prefixed-signal-name scheme
	 * discussed above, as the pass-through configuration is not what we
	 * want when muxing a pin as GPIO for the GPIO subsystem.
	 *
	 * On e.g. the AST2400, a pass-through function "GPID0" is grouped on
	 * balls A18 and D16, where we have:
	 *
	 *    For ball A18:
	 *    - expr->signal set to "GPID0IN"
	 *    - expr->function set to "GPID0"
	 *
	 *    For ball D16:
	 *    - expr->signal set to "GPID0OUT"
	 *    - expr->function set to "GPID0"
	 *
	 * By contrast, the pin-specific GPIO expressions for the same pins are
	 * as follows:
	 *
	 *    For ball A18:
	 *    - expr->signal looks like "GPIOD0"
	 *    - expr->function looks like "GPIOD0"
	 *
	 *    For ball D16:
	 *    - expr->signal looks like "GPIOD1"
	 *    - expr->function looks like "GPIOD1"
	 *
	 * Testing both the signal _and_ function names gives us the means
	 * differentiate the pass-through GPIO pinmux configuration from the
	 * pin-specific configuration that the GPIO subsystem is after: An
	 * expression is a pin-specific (non-pass-through) GPIO configuration
	 * if the signal prefix is "GPI" and the signal name matches the
	 * function name.
	 */
	return strncmp(expr->signal, "GPI", 3) == 0;
	return !strncmp(expr->signal, "GPI", 3) &&
			!strcmp(expr->signal, expr->function);
}

static bool aspeed_gpio_in_exprs(const struct aspeed_sig_expr **exprs)
+4 −3
Original line number Diff line number Diff line
@@ -452,10 +452,11 @@ struct aspeed_sig_desc {
 * evaluation of the descriptors.
 *
 * @signal: The signal name for the priority level on the pin. If the signal
 *          type is GPIO, then the signal name must begin with the string
 *          "GPIO", e.g. GPIOA0, GPIOT4 etc.
 *          type is GPIO, then the signal name must begin with the
 *          prefix "GPI", e.g. GPIOA0, GPIT0 etc.
 * @function: The name of the function the signal participates in for the
 *            associated expression
 *            associated expression. For pin-specific GPIO, the function
 *            name must match the signal name.
 * @ndescs: The number of signal descriptors in the expression
 * @descs: Pointer to an array of signal descriptors that comprise the
 *         function expression
+7 −1
Original line number Diff line number Diff line
@@ -1049,7 +1049,6 @@ static int byt_pin_config_set(struct pinctrl_dev *pctl_dev,
			break;
		case PIN_CONFIG_INPUT_DEBOUNCE:
			debounce = readl(db_reg);
			debounce &= ~BYT_DEBOUNCE_PULSE_MASK;

			if (arg)
				conf |= BYT_DEBOUNCE_EN;
@@ -1058,24 +1057,31 @@ static int byt_pin_config_set(struct pinctrl_dev *pctl_dev,

			switch (arg) {
			case 375:
				debounce &= ~BYT_DEBOUNCE_PULSE_MASK;
				debounce |= BYT_DEBOUNCE_PULSE_375US;
				break;
			case 750:
				debounce &= ~BYT_DEBOUNCE_PULSE_MASK;
				debounce |= BYT_DEBOUNCE_PULSE_750US;
				break;
			case 1500:
				debounce &= ~BYT_DEBOUNCE_PULSE_MASK;
				debounce |= BYT_DEBOUNCE_PULSE_1500US;
				break;
			case 3000:
				debounce &= ~BYT_DEBOUNCE_PULSE_MASK;
				debounce |= BYT_DEBOUNCE_PULSE_3MS;
				break;
			case 6000:
				debounce &= ~BYT_DEBOUNCE_PULSE_MASK;
				debounce |= BYT_DEBOUNCE_PULSE_6MS;
				break;
			case 12000:
				debounce &= ~BYT_DEBOUNCE_PULSE_MASK;
				debounce |= BYT_DEBOUNCE_PULSE_12MS;
				break;
			case 24000:
				debounce &= ~BYT_DEBOUNCE_PULSE_MASK;
				debounce |= BYT_DEBOUNCE_PULSE_24MS;
				break;
			default:
+2 −2
Original line number Diff line number Diff line
@@ -442,8 +442,8 @@ static void intel_gpio_set_gpio_mode(void __iomem *padcfg0)
	value |= PADCFG0_PMODE_GPIO;

	/* Disable input and output buffers */
	value &= ~PADCFG0_GPIORXDIS;
	value &= ~PADCFG0_GPIOTXDIS;
	value |= PADCFG0_GPIORXDIS;
	value |= PADCFG0_GPIOTXDIS;

	/* Disable SCI/SMI/NMI generation */
	value &= ~(PADCFG0_GPIROUTIOXAPIC | PADCFG0_GPIROUTSCI);
+231 −221
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@

#define JSL_PAD_OWN	0x020
#define JSL_PADCFGLOCK	0x080
#define JSL_HOSTSW_OWN	0x0b0
#define JSL_HOSTSW_OWN	0x0c0
#define JSL_GPI_IS	0x100
#define JSL_GPI_IE	0x120

@@ -65,252 +65,263 @@ static const struct pinctrl_pin_desc jsl_pins[] = {
	PINCTRL_PIN(17, "EMMC_CLK"),
	PINCTRL_PIN(18, "EMMC_RESETB"),
	PINCTRL_PIN(19, "A4WP_PRESENT"),
	/* SPI */
	PINCTRL_PIN(20, "SPI0_IO_2"),
	PINCTRL_PIN(21, "SPI0_IO_3"),
	PINCTRL_PIN(22, "SPI0_MOSI_IO_0"),
	PINCTRL_PIN(23, "SPI0_MISO_IO_1"),
	PINCTRL_PIN(24, "SPI0_TPM_CSB"),
	PINCTRL_PIN(25, "SPI0_FLASH_0_CSB"),
	PINCTRL_PIN(26, "SPI0_FLASH_1_CSB"),
	PINCTRL_PIN(27, "SPI0_CLK"),
	PINCTRL_PIN(28, "SPI0_CLK_LOOPBK"),
	/* GPP_B */
	PINCTRL_PIN(20, "CORE_VID_0"),
	PINCTRL_PIN(21, "CORE_VID_1"),
	PINCTRL_PIN(22, "VRALERTB"),
	PINCTRL_PIN(23, "CPU_GP_2"),
	PINCTRL_PIN(24, "CPU_GP_3"),
	PINCTRL_PIN(25, "SRCCLKREQB_0"),
	PINCTRL_PIN(26, "SRCCLKREQB_1"),
	PINCTRL_PIN(27, "SRCCLKREQB_2"),
	PINCTRL_PIN(28, "SRCCLKREQB_3"),
	PINCTRL_PIN(29, "SRCCLKREQB_4"),
	PINCTRL_PIN(30, "SRCCLKREQB_5"),
	PINCTRL_PIN(31, "PMCALERTB"),
	PINCTRL_PIN(32, "SLP_S0B"),
	PINCTRL_PIN(33, "PLTRSTB"),
	PINCTRL_PIN(34, "SPKR"),
	PINCTRL_PIN(35, "GSPI0_CS0B"),
	PINCTRL_PIN(36, "GSPI0_CLK"),
	PINCTRL_PIN(37, "GSPI0_MISO"),
	PINCTRL_PIN(38, "GSPI0_MOSI"),
	PINCTRL_PIN(39, "GSPI1_CS0B"),
	PINCTRL_PIN(40, "GSPI1_CLK"),
	PINCTRL_PIN(41, "GSPI1_MISO"),
	PINCTRL_PIN(42, "GSPI1_MOSI"),
	PINCTRL_PIN(43, "DDSP_HPD_A"),
	PINCTRL_PIN(44, "GSPI0_CLK_LOOPBK"),
	PINCTRL_PIN(45, "GSPI1_CLK_LOOPBK"),
	PINCTRL_PIN(29, "CORE_VID_0"),
	PINCTRL_PIN(30, "CORE_VID_1"),
	PINCTRL_PIN(31, "VRALERTB"),
	PINCTRL_PIN(32, "CPU_GP_2"),
	PINCTRL_PIN(33, "CPU_GP_3"),
	PINCTRL_PIN(34, "SRCCLKREQB_0"),
	PINCTRL_PIN(35, "SRCCLKREQB_1"),
	PINCTRL_PIN(36, "SRCCLKREQB_2"),
	PINCTRL_PIN(37, "SRCCLKREQB_3"),
	PINCTRL_PIN(38, "SRCCLKREQB_4"),
	PINCTRL_PIN(39, "SRCCLKREQB_5"),
	PINCTRL_PIN(40, "PMCALERTB"),
	PINCTRL_PIN(41, "SLP_S0B"),
	PINCTRL_PIN(42, "PLTRSTB"),
	PINCTRL_PIN(43, "SPKR"),
	PINCTRL_PIN(44, "GSPI0_CS0B"),
	PINCTRL_PIN(45, "GSPI0_CLK"),
	PINCTRL_PIN(46, "GSPI0_MISO"),
	PINCTRL_PIN(47, "GSPI0_MOSI"),
	PINCTRL_PIN(48, "GSPI1_CS0B"),
	PINCTRL_PIN(49, "GSPI1_CLK"),
	PINCTRL_PIN(50, "GSPI1_MISO"),
	PINCTRL_PIN(51, "GSPI1_MOSI"),
	PINCTRL_PIN(52, "DDSP_HPD_A"),
	PINCTRL_PIN(53, "GSPI0_CLK_LOOPBK"),
	PINCTRL_PIN(54, "GSPI1_CLK_LOOPBK"),
	/* GPP_A */
	PINCTRL_PIN(46, "ESPI_IO_0"),
	PINCTRL_PIN(47, "ESPI_IO_1"),
	PINCTRL_PIN(48, "ESPI_IO_2"),
	PINCTRL_PIN(49, "ESPI_IO_3"),
	PINCTRL_PIN(50, "ESPI_CSB"),
	PINCTRL_PIN(51, "ESPI_CLK"),
	PINCTRL_PIN(52, "ESPI_RESETB"),
	PINCTRL_PIN(53, "SMBCLK"),
	PINCTRL_PIN(54, "SMBDATA"),
	PINCTRL_PIN(55, "SMBALERTB"),
	PINCTRL_PIN(56, "CPU_GP_0"),
	PINCTRL_PIN(57, "CPU_GP_1"),
	PINCTRL_PIN(58, "USB2_OCB_1"),
	PINCTRL_PIN(59, "USB2_OCB_2"),
	PINCTRL_PIN(60, "USB2_OCB_3"),
	PINCTRL_PIN(61, "DDSP_HPD_A_TIME_SYNC_0"),
	PINCTRL_PIN(62, "DDSP_HPD_B"),
	PINCTRL_PIN(63, "DDSP_HPD_C"),
	PINCTRL_PIN(64, "USB2_OCB_0"),
	PINCTRL_PIN(65, "PCHHOTB"),
	PINCTRL_PIN(66, "ESPI_CLK_LOOPBK"),
	PINCTRL_PIN(55, "ESPI_IO_0"),
	PINCTRL_PIN(56, "ESPI_IO_1"),
	PINCTRL_PIN(57, "ESPI_IO_2"),
	PINCTRL_PIN(58, "ESPI_IO_3"),
	PINCTRL_PIN(59, "ESPI_CSB"),
	PINCTRL_PIN(60, "ESPI_CLK"),
	PINCTRL_PIN(61, "ESPI_RESETB"),
	PINCTRL_PIN(62, "SMBCLK"),
	PINCTRL_PIN(63, "SMBDATA"),
	PINCTRL_PIN(64, "SMBALERTB"),
	PINCTRL_PIN(65, "CPU_GP_0"),
	PINCTRL_PIN(66, "CPU_GP_1"),
	PINCTRL_PIN(67, "USB2_OCB_1"),
	PINCTRL_PIN(68, "USB2_OCB_2"),
	PINCTRL_PIN(69, "USB2_OCB_3"),
	PINCTRL_PIN(70, "DDSP_HPD_A_TIME_SYNC_0"),
	PINCTRL_PIN(71, "DDSP_HPD_B"),
	PINCTRL_PIN(72, "DDSP_HPD_C"),
	PINCTRL_PIN(73, "USB2_OCB_0"),
	PINCTRL_PIN(74, "PCHHOTB"),
	PINCTRL_PIN(75, "ESPI_CLK_LOOPBK"),
	/* GPP_S */
	PINCTRL_PIN(67, "SNDW1_CLK"),
	PINCTRL_PIN(68, "SNDW1_DATA"),
	PINCTRL_PIN(69, "SNDW2_CLK"),
	PINCTRL_PIN(70, "SNDW2_DATA"),
	PINCTRL_PIN(71, "SNDW1_CLK"),
	PINCTRL_PIN(72, "SNDW1_DATA"),
	PINCTRL_PIN(73, "SNDW4_CLK_DMIC_CLK_0"),
	PINCTRL_PIN(74, "SNDW4_DATA_DMIC_DATA_0"),
	PINCTRL_PIN(76, "SNDW1_CLK"),
	PINCTRL_PIN(77, "SNDW1_DATA"),
	PINCTRL_PIN(78, "SNDW2_CLK"),
	PINCTRL_PIN(79, "SNDW2_DATA"),
	PINCTRL_PIN(80, "SNDW1_CLK"),
	PINCTRL_PIN(81, "SNDW1_DATA"),
	PINCTRL_PIN(82, "SNDW4_CLK_DMIC_CLK_0"),
	PINCTRL_PIN(83, "SNDW4_DATA_DMIC_DATA_0"),
	/* GPP_R */
	PINCTRL_PIN(75, "HDA_BCLK"),
	PINCTRL_PIN(76, "HDA_SYNC"),
	PINCTRL_PIN(77, "HDA_SDO"),
	PINCTRL_PIN(78, "HDA_SDI_0"),
	PINCTRL_PIN(79, "HDA_RSTB"),
	PINCTRL_PIN(80, "HDA_SDI_1"),
	PINCTRL_PIN(81, "I2S1_SFRM"),
	PINCTRL_PIN(82, "I2S1_TXD"),
	PINCTRL_PIN(84, "HDA_BCLK"),
	PINCTRL_PIN(85, "HDA_SYNC"),
	PINCTRL_PIN(86, "HDA_SDO"),
	PINCTRL_PIN(87, "HDA_SDI_0"),
	PINCTRL_PIN(88, "HDA_RSTB"),
	PINCTRL_PIN(89, "HDA_SDI_1"),
	PINCTRL_PIN(90, "I2S1_SFRM"),
	PINCTRL_PIN(91, "I2S1_TXD"),
	/* GPP_H */
	PINCTRL_PIN(83, "GPPC_H_0"),
	PINCTRL_PIN(84, "SD_PWR_EN_B"),
	PINCTRL_PIN(85, "MODEM_CLKREQ"),
	PINCTRL_PIN(86, "SX_EXIT_HOLDOFFB"),
	PINCTRL_PIN(87, "I2C2_SDA"),
	PINCTRL_PIN(88, "I2C2_SCL"),
	PINCTRL_PIN(89, "I2C3_SDA"),
	PINCTRL_PIN(90, "I2C3_SCL"),
	PINCTRL_PIN(91, "I2C4_SDA"),
	PINCTRL_PIN(92, "I2C4_SCL"),
	PINCTRL_PIN(93, "CPU_VCCIO_PWR_GATEB"),
	PINCTRL_PIN(94, "I2S2_SCLK"),
	PINCTRL_PIN(95, "I2S2_SFRM"),
	PINCTRL_PIN(96, "I2S2_TXD"),
	PINCTRL_PIN(97, "I2S2_RXD"),
	PINCTRL_PIN(98, "I2S1_SCLK"),
	PINCTRL_PIN(99, "GPPC_H_16"),
	PINCTRL_PIN(100, "GPPC_H_17"),
	PINCTRL_PIN(101, "GPPC_H_18"),
	PINCTRL_PIN(102, "GPPC_H_19"),
	PINCTRL_PIN(103, "GPPC_H_20"),
	PINCTRL_PIN(104, "GPPC_H_21"),
	PINCTRL_PIN(105, "GPPC_H_22"),
	PINCTRL_PIN(106, "GPPC_H_23"),
	PINCTRL_PIN(92, "GPPC_H_0"),
	PINCTRL_PIN(93, "SD_PWR_EN_B"),
	PINCTRL_PIN(94, "MODEM_CLKREQ"),
	PINCTRL_PIN(95, "SX_EXIT_HOLDOFFB"),
	PINCTRL_PIN(96, "I2C2_SDA"),
	PINCTRL_PIN(97, "I2C2_SCL"),
	PINCTRL_PIN(98, "I2C3_SDA"),
	PINCTRL_PIN(99, "I2C3_SCL"),
	PINCTRL_PIN(100, "I2C4_SDA"),
	PINCTRL_PIN(101, "I2C4_SCL"),
	PINCTRL_PIN(102, "CPU_VCCIO_PWR_GATEB"),
	PINCTRL_PIN(103, "I2S2_SCLK"),
	PINCTRL_PIN(104, "I2S2_SFRM"),
	PINCTRL_PIN(105, "I2S2_TXD"),
	PINCTRL_PIN(106, "I2S2_RXD"),
	PINCTRL_PIN(107, "I2S1_SCLK"),
	PINCTRL_PIN(108, "GPPC_H_16"),
	PINCTRL_PIN(109, "GPPC_H_17"),
	PINCTRL_PIN(110, "GPPC_H_18"),
	PINCTRL_PIN(111, "GPPC_H_19"),
	PINCTRL_PIN(112, "GPPC_H_20"),
	PINCTRL_PIN(113, "GPPC_H_21"),
	PINCTRL_PIN(114, "GPPC_H_22"),
	PINCTRL_PIN(115, "GPPC_H_23"),
	/* GPP_D */
	PINCTRL_PIN(107, "SPI1_CSB"),
	PINCTRL_PIN(108, "SPI1_CLK"),
	PINCTRL_PIN(109, "SPI1_MISO_IO_1"),
	PINCTRL_PIN(110, "SPI1_MOSI_IO_0"),
	PINCTRL_PIN(111, "ISH_I2C0_SDA"),
	PINCTRL_PIN(112, "ISH_I2C0_SCL"),
	PINCTRL_PIN(113, "ISH_I2C1_SDA"),
	PINCTRL_PIN(114, "ISH_I2C1_SCL"),
	PINCTRL_PIN(115, "ISH_SPI_CSB"),
	PINCTRL_PIN(116, "ISH_SPI_CLK"),
	PINCTRL_PIN(117, "ISH_SPI_MISO"),
	PINCTRL_PIN(118, "ISH_SPI_MOSI"),
	PINCTRL_PIN(119, "ISH_UART0_RXD"),
	PINCTRL_PIN(120, "ISH_UART0_TXD"),
	PINCTRL_PIN(121, "ISH_UART0_RTSB"),
	PINCTRL_PIN(122, "ISH_UART0_CTSB"),
	PINCTRL_PIN(123, "SPI1_IO_2"),
	PINCTRL_PIN(124, "SPI1_IO_3"),
	PINCTRL_PIN(125, "I2S_MCLK"),
	PINCTRL_PIN(126, "CNV_MFUART2_RXD"),
	PINCTRL_PIN(127, "CNV_MFUART2_TXD"),
	PINCTRL_PIN(128, "CNV_PA_BLANKING"),
	PINCTRL_PIN(129, "I2C5_SDA"),
	PINCTRL_PIN(130, "I2C5_SCL"),
	PINCTRL_PIN(131, "GSPI2_CLK_LOOPBK"),
	PINCTRL_PIN(132, "SPI1_CLK_LOOPBK"),
	PINCTRL_PIN(116, "SPI1_CSB"),
	PINCTRL_PIN(117, "SPI1_CLK"),
	PINCTRL_PIN(118, "SPI1_MISO_IO_1"),
	PINCTRL_PIN(119, "SPI1_MOSI_IO_0"),
	PINCTRL_PIN(120, "ISH_I2C0_SDA"),
	PINCTRL_PIN(121, "ISH_I2C0_SCL"),
	PINCTRL_PIN(122, "ISH_I2C1_SDA"),
	PINCTRL_PIN(123, "ISH_I2C1_SCL"),
	PINCTRL_PIN(124, "ISH_SPI_CSB"),
	PINCTRL_PIN(125, "ISH_SPI_CLK"),
	PINCTRL_PIN(126, "ISH_SPI_MISO"),
	PINCTRL_PIN(127, "ISH_SPI_MOSI"),
	PINCTRL_PIN(128, "ISH_UART0_RXD"),
	PINCTRL_PIN(129, "ISH_UART0_TXD"),
	PINCTRL_PIN(130, "ISH_UART0_RTSB"),
	PINCTRL_PIN(131, "ISH_UART0_CTSB"),
	PINCTRL_PIN(132, "SPI1_IO_2"),
	PINCTRL_PIN(133, "SPI1_IO_3"),
	PINCTRL_PIN(134, "I2S_MCLK"),
	PINCTRL_PIN(135, "CNV_MFUART2_RXD"),
	PINCTRL_PIN(136, "CNV_MFUART2_TXD"),
	PINCTRL_PIN(137, "CNV_PA_BLANKING"),
	PINCTRL_PIN(138, "I2C5_SDA"),
	PINCTRL_PIN(139, "I2C5_SCL"),
	PINCTRL_PIN(140, "GSPI2_CLK_LOOPBK"),
	PINCTRL_PIN(141, "SPI1_CLK_LOOPBK"),
	/* vGPIO */
	PINCTRL_PIN(133, "CNV_BTEN"),
	PINCTRL_PIN(134, "CNV_WCEN"),
	PINCTRL_PIN(135, "CNV_BT_HOST_WAKEB"),
	PINCTRL_PIN(136, "CNV_BT_IF_SELECT"),
	PINCTRL_PIN(137, "vCNV_BT_UART_TXD"),
	PINCTRL_PIN(138, "vCNV_BT_UART_RXD"),
	PINCTRL_PIN(139, "vCNV_BT_UART_CTS_B"),
	PINCTRL_PIN(140, "vCNV_BT_UART_RTS_B"),
	PINCTRL_PIN(141, "vCNV_MFUART1_TXD"),
	PINCTRL_PIN(142, "vCNV_MFUART1_RXD"),
	PINCTRL_PIN(143, "vCNV_MFUART1_CTS_B"),
	PINCTRL_PIN(144, "vCNV_MFUART1_RTS_B"),
	PINCTRL_PIN(145, "vUART0_TXD"),
	PINCTRL_PIN(146, "vUART0_RXD"),
	PINCTRL_PIN(147, "vUART0_CTS_B"),
	PINCTRL_PIN(148, "vUART0_RTS_B"),
	PINCTRL_PIN(149, "vISH_UART0_TXD"),
	PINCTRL_PIN(150, "vISH_UART0_RXD"),
	PINCTRL_PIN(151, "vISH_UART0_CTS_B"),
	PINCTRL_PIN(152, "vISH_UART0_RTS_B"),
	PINCTRL_PIN(153, "vCNV_BT_I2S_BCLK"),
	PINCTRL_PIN(154, "vCNV_BT_I2S_WS_SYNC"),
	PINCTRL_PIN(155, "vCNV_BT_I2S_SDO"),
	PINCTRL_PIN(156, "vCNV_BT_I2S_SDI"),
	PINCTRL_PIN(157, "vI2S2_SCLK"),
	PINCTRL_PIN(158, "vI2S2_SFRM"),
	PINCTRL_PIN(159, "vI2S2_TXD"),
	PINCTRL_PIN(160, "vI2S2_RXD"),
	PINCTRL_PIN(161, "vSD3_CD_B"),
	PINCTRL_PIN(142, "CNV_BTEN"),
	PINCTRL_PIN(143, "CNV_WCEN"),
	PINCTRL_PIN(144, "CNV_BT_HOST_WAKEB"),
	PINCTRL_PIN(145, "CNV_BT_IF_SELECT"),
	PINCTRL_PIN(146, "vCNV_BT_UART_TXD"),
	PINCTRL_PIN(147, "vCNV_BT_UART_RXD"),
	PINCTRL_PIN(148, "vCNV_BT_UART_CTS_B"),
	PINCTRL_PIN(149, "vCNV_BT_UART_RTS_B"),
	PINCTRL_PIN(150, "vCNV_MFUART1_TXD"),
	PINCTRL_PIN(151, "vCNV_MFUART1_RXD"),
	PINCTRL_PIN(152, "vCNV_MFUART1_CTS_B"),
	PINCTRL_PIN(153, "vCNV_MFUART1_RTS_B"),
	PINCTRL_PIN(154, "vUART0_TXD"),
	PINCTRL_PIN(155, "vUART0_RXD"),
	PINCTRL_PIN(156, "vUART0_CTS_B"),
	PINCTRL_PIN(157, "vUART0_RTS_B"),
	PINCTRL_PIN(158, "vISH_UART0_TXD"),
	PINCTRL_PIN(159, "vISH_UART0_RXD"),
	PINCTRL_PIN(160, "vISH_UART0_CTS_B"),
	PINCTRL_PIN(161, "vISH_UART0_RTS_B"),
	PINCTRL_PIN(162, "vCNV_BT_I2S_BCLK"),
	PINCTRL_PIN(163, "vCNV_BT_I2S_WS_SYNC"),
	PINCTRL_PIN(164, "vCNV_BT_I2S_SDO"),
	PINCTRL_PIN(165, "vCNV_BT_I2S_SDI"),
	PINCTRL_PIN(166, "vI2S2_SCLK"),
	PINCTRL_PIN(167, "vI2S2_SFRM"),
	PINCTRL_PIN(168, "vI2S2_TXD"),
	PINCTRL_PIN(169, "vI2S2_RXD"),
	PINCTRL_PIN(170, "vSD3_CD_B"),
	/* GPP_C */
	PINCTRL_PIN(162, "GPPC_C_0"),
	PINCTRL_PIN(163, "GPPC_C_1"),
	PINCTRL_PIN(164, "GPPC_C_2"),
	PINCTRL_PIN(165, "GPPC_C_3"),
	PINCTRL_PIN(166, "GPPC_C_4"),
	PINCTRL_PIN(167, "GPPC_C_5"),
	PINCTRL_PIN(168, "SUSWARNB_SUSPWRDNACK"),
	PINCTRL_PIN(169, "SUSACKB"),
	PINCTRL_PIN(170, "UART0_RXD"),
	PINCTRL_PIN(171, "UART0_TXD"),
	PINCTRL_PIN(172, "UART0_RTSB"),
	PINCTRL_PIN(173, "UART0_CTSB"),
	PINCTRL_PIN(174, "UART1_RXD"),
	PINCTRL_PIN(175, "UART1_TXD"),
	PINCTRL_PIN(176, "UART1_RTSB"),
	PINCTRL_PIN(177, "UART1_CTSB"),
	PINCTRL_PIN(178, "I2C0_SDA"),
	PINCTRL_PIN(179, "I2C0_SCL"),
	PINCTRL_PIN(180, "I2C1_SDA"),
	PINCTRL_PIN(181, "I2C1_SCL"),
	PINCTRL_PIN(182, "UART2_RXD"),
	PINCTRL_PIN(183, "UART2_TXD"),
	PINCTRL_PIN(184, "UART2_RTSB"),
	PINCTRL_PIN(185, "UART2_CTSB"),
	PINCTRL_PIN(171, "GPPC_C_0"),
	PINCTRL_PIN(172, "GPPC_C_1"),
	PINCTRL_PIN(173, "GPPC_C_2"),
	PINCTRL_PIN(174, "GPPC_C_3"),
	PINCTRL_PIN(175, "GPPC_C_4"),
	PINCTRL_PIN(176, "GPPC_C_5"),
	PINCTRL_PIN(177, "SUSWARNB_SUSPWRDNACK"),
	PINCTRL_PIN(178, "SUSACKB"),
	PINCTRL_PIN(179, "UART0_RXD"),
	PINCTRL_PIN(180, "UART0_TXD"),
	PINCTRL_PIN(181, "UART0_RTSB"),
	PINCTRL_PIN(182, "UART0_CTSB"),
	PINCTRL_PIN(183, "UART1_RXD"),
	PINCTRL_PIN(184, "UART1_TXD"),
	PINCTRL_PIN(185, "UART1_RTSB"),
	PINCTRL_PIN(186, "UART1_CTSB"),
	PINCTRL_PIN(187, "I2C0_SDA"),
	PINCTRL_PIN(188, "I2C0_SCL"),
	PINCTRL_PIN(189, "I2C1_SDA"),
	PINCTRL_PIN(190, "I2C1_SCL"),
	PINCTRL_PIN(191, "UART2_RXD"),
	PINCTRL_PIN(192, "UART2_TXD"),
	PINCTRL_PIN(193, "UART2_RTSB"),
	PINCTRL_PIN(194, "UART2_CTSB"),
	/* HVCMOS */
	PINCTRL_PIN(186, "L_BKLTEN"),
	PINCTRL_PIN(187, "L_BKLTCTL"),
	PINCTRL_PIN(188, "L_VDDEN"),
	PINCTRL_PIN(189, "SYS_PWROK"),
	PINCTRL_PIN(190, "SYS_RESETB"),
	PINCTRL_PIN(191, "MLK_RSTB"),
	PINCTRL_PIN(195, "L_BKLTEN"),
	PINCTRL_PIN(196, "L_BKLTCTL"),
	PINCTRL_PIN(197, "L_VDDEN"),
	PINCTRL_PIN(198, "SYS_PWROK"),
	PINCTRL_PIN(199, "SYS_RESETB"),
	PINCTRL_PIN(200, "MLK_RSTB"),
	/* GPP_E */
	PINCTRL_PIN(192, "ISH_GP_0"),
	PINCTRL_PIN(193, "ISH_GP_1"),
	PINCTRL_PIN(194, "IMGCLKOUT_1"),
	PINCTRL_PIN(195, "ISH_GP_2"),
	PINCTRL_PIN(196, "IMGCLKOUT_2"),
	PINCTRL_PIN(197, "SATA_LEDB"),
	PINCTRL_PIN(198, "IMGCLKOUT_3"),
	PINCTRL_PIN(199, "ISH_GP_3"),
	PINCTRL_PIN(200, "ISH_GP_4"),
	PINCTRL_PIN(201, "ISH_GP_5"),
	PINCTRL_PIN(202, "ISH_GP_6"),
	PINCTRL_PIN(203, "ISH_GP_7"),
	PINCTRL_PIN(204, "IMGCLKOUT_4"),
	PINCTRL_PIN(205, "DDPA_CTRLCLK"),
	PINCTRL_PIN(206, "DDPA_CTRLDATA"),
	PINCTRL_PIN(207, "DDPB_CTRLCLK"),
	PINCTRL_PIN(208, "DDPB_CTRLDATA"),
	PINCTRL_PIN(209, "DDPC_CTRLCLK"),
	PINCTRL_PIN(210, "DDPC_CTRLDATA"),
	PINCTRL_PIN(211, "IMGCLKOUT_5"),
	PINCTRL_PIN(212, "CNV_BRI_DT"),
	PINCTRL_PIN(213, "CNV_BRI_RSP"),
	PINCTRL_PIN(214, "CNV_RGI_DT"),
	PINCTRL_PIN(215, "CNV_RGI_RSP"),
	PINCTRL_PIN(201, "ISH_GP_0"),
	PINCTRL_PIN(202, "ISH_GP_1"),
	PINCTRL_PIN(203, "IMGCLKOUT_1"),
	PINCTRL_PIN(204, "ISH_GP_2"),
	PINCTRL_PIN(205, "IMGCLKOUT_2"),
	PINCTRL_PIN(206, "SATA_LEDB"),
	PINCTRL_PIN(207, "IMGCLKOUT_3"),
	PINCTRL_PIN(208, "ISH_GP_3"),
	PINCTRL_PIN(209, "ISH_GP_4"),
	PINCTRL_PIN(210, "ISH_GP_5"),
	PINCTRL_PIN(211, "ISH_GP_6"),
	PINCTRL_PIN(212, "ISH_GP_7"),
	PINCTRL_PIN(213, "IMGCLKOUT_4"),
	PINCTRL_PIN(214, "DDPA_CTRLCLK"),
	PINCTRL_PIN(215, "DDPA_CTRLDATA"),
	PINCTRL_PIN(216, "DDPB_CTRLCLK"),
	PINCTRL_PIN(217, "DDPB_CTRLDATA"),
	PINCTRL_PIN(218, "DDPC_CTRLCLK"),
	PINCTRL_PIN(219, "DDPC_CTRLDATA"),
	PINCTRL_PIN(220, "IMGCLKOUT_5"),
	PINCTRL_PIN(221, "CNV_BRI_DT"),
	PINCTRL_PIN(222, "CNV_BRI_RSP"),
	PINCTRL_PIN(223, "CNV_RGI_DT"),
	PINCTRL_PIN(224, "CNV_RGI_RSP"),
	/* GPP_G */
	PINCTRL_PIN(216, "SD3_CMD"),
	PINCTRL_PIN(217, "SD3_D0"),
	PINCTRL_PIN(218, "SD3_D1"),
	PINCTRL_PIN(219, "SD3_D2"),
	PINCTRL_PIN(220, "SD3_D3"),
	PINCTRL_PIN(221, "SD3_CDB"),
	PINCTRL_PIN(222, "SD3_CLK"),
	PINCTRL_PIN(223, "SD3_WP"),
	PINCTRL_PIN(225, "SD3_CMD"),
	PINCTRL_PIN(226, "SD3_D0"),
	PINCTRL_PIN(227, "SD3_D1"),
	PINCTRL_PIN(228, "SD3_D2"),
	PINCTRL_PIN(229, "SD3_D3"),
	PINCTRL_PIN(230, "SD3_CDB"),
	PINCTRL_PIN(231, "SD3_CLK"),
	PINCTRL_PIN(232, "SD3_WP"),
};

static const struct intel_padgroup jsl_community0_gpps[] = {
	JSL_GPP(0, 0, 19, 320),				/* GPP_F */
	JSL_GPP(1, 20, 45, 32),				/* GPP_B */
	JSL_GPP(2, 46, 66, 64),				/* GPP_A */
	JSL_GPP(3, 67, 74, 96),				/* GPP_S */
	JSL_GPP(4, 75, 82, 128),			/* GPP_R */
	JSL_GPP(1, 20, 28, INTEL_GPIO_BASE_NOMAP),	/* SPI */
	JSL_GPP(2, 29, 54, 32),				/* GPP_B */
	JSL_GPP(3, 55, 75, 64),				/* GPP_A */
	JSL_GPP(4, 76, 83, 96),				/* GPP_S */
	JSL_GPP(5, 84, 91, 128),			/* GPP_R */
};

static const struct intel_padgroup jsl_community1_gpps[] = {
	JSL_GPP(0, 83, 106, 160),			/* GPP_H */
	JSL_GPP(1, 107, 132, 192),			/* GPP_D */
	JSL_GPP(2, 133, 161, 224),			/* vGPIO */
	JSL_GPP(3, 162, 185, 256),			/* GPP_C */
	JSL_GPP(0, 92, 115, 160),			/* GPP_H */
	JSL_GPP(1, 116, 141, 192),			/* GPP_D */
	JSL_GPP(2, 142, 170, 224),			/* vGPIO */
	JSL_GPP(3, 171, 194, 256),			/* GPP_C */
};

static const struct intel_padgroup jsl_community4_gpps[] = {
	JSL_GPP(0, 186, 191, INTEL_GPIO_BASE_NOMAP),	/* HVCMOS */
	JSL_GPP(1, 192, 215, 288),			/* GPP_E */
	JSL_GPP(0, 195, 200, INTEL_GPIO_BASE_NOMAP),	/* HVCMOS */
	JSL_GPP(1, 201, 224, 288),			/* GPP_E */
};

static const struct intel_padgroup jsl_community5_gpps[] = {
	JSL_GPP(0, 216, 223, INTEL_GPIO_BASE_ZERO),	/* GPP_G */
	JSL_GPP(0, 225, 232, INTEL_GPIO_BASE_ZERO),	/* GPP_G */
};

static const struct intel_community jsl_communities[] = {
	JSL_COMMUNITY(0, 0, 82, jsl_community0_gpps),
	JSL_COMMUNITY(1, 83, 185, jsl_community1_gpps),
	JSL_COMMUNITY(2, 186, 215, jsl_community4_gpps),
	JSL_COMMUNITY(3, 216, 223, jsl_community5_gpps),
	JSL_COMMUNITY(0, 0, 91, jsl_community0_gpps),
	JSL_COMMUNITY(1, 92, 194, jsl_community1_gpps),
	JSL_COMMUNITY(2, 195, 224, jsl_community4_gpps),
	JSL_COMMUNITY(3, 225, 232, jsl_community5_gpps),
};

static const struct intel_pinctrl_soc_data jsl_soc_data = {
@@ -336,7 +347,6 @@ static struct platform_driver jsl_pinctrl_driver = {
		.pm = &jsl_pinctrl_pm_ops,
	},
};

module_platform_driver(jsl_pinctrl_driver);

MODULE_AUTHOR("Andy Shevchenko <andriy.shevchenko@linux.intel.com>");
Loading