bpf: explicitly prohibit ctx_{in, out} in non-skb BPF_PROG_TEST_RUN (947e8b59) · Commits · 戴 / test

This should allow us later to extend BPF_PROG_TEST_RUN for non-skb case and be sure that nobody is erroneously setting ctx_{in,out}. Fixes: ("bpf: support input __sk_buff context in BPF_PROG_TEST_RUN") Reported-by:

Daniel Borkmann <daniel@iogearbox.net> Signed-off-by:

Stanislav Fomichev <sdf@google.com> Signed-off-by:

Daniel Borkmann <daniel@iogearbox.net>

net/bpf/test_run.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -347,6 +347,9 @@ int bpf_prog_test_run_xdp(struct bpf_prog prog, const union bpf_attr kattr,
		void *data;
		int ret;

		if (kattr->test.ctx_in \|\| kattr->test.ctx_out)
		return -EINVAL;

		data = bpf_test_init(kattr, size, XDP_PACKET_HEADROOM + NET_IP_ALIGN, 0);
		if (IS_ERR(data))
		return PTR_ERR(data);
		@@ -390,6 +393,9 @@ int bpf_prog_test_run_flow_dissector(struct bpf_prog *prog,
		if (prog->type != BPF_PROG_TYPE_FLOW_DISSECTOR)
		return -EINVAL;

		if (kattr->test.ctx_in \|\| kattr->test.ctx_out)
		return -EINVAL;

		data = bpf_test_init(kattr, size, NET_SKB_PAD + NET_IP_ALIGN,
		SKB_DATA_ALIGN(sizeof(struct skb_shared_info)));
		if (IS_ERR(data))

Admin message