perf trace: Allocate an array of beautifiers for tracepoint args (947b843c) · Commits · 戴 / test

This will work similar to the syscall args, we'll allocate an array of 'struct syscall_arg_fmt' for the tracepoint args and then init them using the same algorithm used for the defaults for syscall args, i.e. using its types and sometimes names as hints to find the right scnprintf routine to beautify them from numbers into strings. Next step is to stop using libtracevent to printf tracepoints, as we'll have more beautifiers than int provides, modulo perhaps some plugins. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://lkml.kernel.org/n/tip-dcl135relxvf6ljisjg13aqg@git.kernel.org Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/builtin-trace.c

+16 −1

Original line number	Diff line number	Diff line
		@@ -1574,6 +1574,19 @@ static int trace__read_syscall_info(struct trace *trace, int id)
		return syscall__set_arg_fmts(sc);
		}

		static int perf_evsel__init_tp_arg_scnprintf(struct evsel *evsel)
		{
		int nr_args = evsel->tp_format->format.nr_fields;

		evsel->priv = calloc(nr_args, sizeof(struct syscall_arg_fmt));
		if (evsel->priv != NULL) {
		syscall_arg_fmt__init_array(evsel->priv, evsel->tp_format->format.fields);
		return 0;
		}

		return -ENOMEM;
		}

		static int intcmp(const void a, const void b)
		{
		const int one = a, another = b;
		@@ -3936,8 +3949,10 @@ static int evlist__set_syscall_tp_fields(struct evlist *evlist)
		if (evsel->priv \|\| !evsel->tp_format)
		continue;

		if (strcmp(evsel->tp_format->system, "syscalls"))
		if (strcmp(evsel->tp_format->system, "syscalls")) {
		perf_evsel__init_tp_arg_scnprintf(evsel);
		continue;
		}

		if (perf_evsel__init_syscall_tp(evsel))
		return -1;

Admin message