Commit 945f0ee2 authored Dec 08, 2006 by Amol Lad Committed by Linus Torvalds Dec 08, 2006

[PATCH] ioremap balanced with iounmap for drivers/video/S3triofb



ioremap must be balanced by an iounmap and failing to do so can result in a
memory leak.

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 57354c42

drivers/video/S3triofb.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -535,8 +535,11 @@ static void __init s3triofb_of_init(struct device_node *dp)
		#endif

		fb_info.flags = FBINFO_FLAG_DEFAULT;
		if (register_framebuffer(&fb_info) < 0)
		if (register_framebuffer(&fb_info) < 0) {
		iounmap(fb_info.screen_base);
		fb_info.screen_base = NULL;
		return;
		}

		printk("fb%d: S3 Trio frame buffer device on %s\n",
		fb_info.node, dp->full_name);

Admin message