Commit 94563847 authored by Eran Ben Elisha's avatar Eran Ben Elisha Committed by Saeed Mahameed
Browse files

net/mlx5e: Add new counter for aRFS rule insertion failures 



Count aRFS rules insertion failure for ethtool output. In addition, move
the error print into debug prints mechanism, as it could flood the dmesg
and reduce system BW dramatically.

Signed-off-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Reviewed-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent e98bedf5

drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c

+5 −2
Original line number Diff line number Diff line
@@ -543,8 +543,11 @@ static struct mlx5_flow_handle *arfs_add_rule(struct mlx5e_priv *priv, 
	rule = mlx5_add_flow_rules(ft, spec, &flow_act, &dest, 1);

	if (IS_ERR(rule)) {

		err = PTR_ERR(rule);

		netdev_err(priv->netdev, "%s: add rule(filter id=%d, rq idx=%d) failed, err=%d\n",

			   __func__, arfs_rule->filter_id, arfs_rule->rxq, err);

		priv->channel_stats[arfs_rule->rxq].rq.arfs_err++;

		mlx5e_dbg(HW, priv,

			  "%s: add rule(filter id=%d, rq idx=%d, ip proto=0x%x) failed,err=%d\n",

			  __func__, arfs_rule->filter_id, arfs_rule->rxq,

			  tuple->ip_proto, err);

	}



out:

drivers/net/ethernet/mellanox/mlx5/core/en_stats.c

+3 −0
Original line number Diff line number Diff line
@@ -93,6 +93,7 @@ static const struct counter_desc sw_stats_desc[] = { 
	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_cache_busy) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_cache_waive) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_congst_umr) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_arfs_err) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, ch_events) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, ch_poll) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, ch_arm) },
@@ -170,6 +171,7 @@ void mlx5e_grp_sw_update_stats(struct mlx5e_priv *priv) 
		s->rx_cache_busy  += rq_stats->cache_busy;

		s->rx_cache_waive += rq_stats->cache_waive;

		s->rx_congst_umr  += rq_stats->congst_umr;

		s->rx_arfs_err    += rq_stats->arfs_err;

		s->ch_events      += ch_stats->events;

		s->ch_poll        += ch_stats->poll;

		s->ch_arm         += ch_stats->arm;
@@ -1161,6 +1163,7 @@ static const struct counter_desc rq_stats_desc[] = { 
	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, cache_busy) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, cache_waive) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, congst_umr) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, arfs_err) },

};



static const struct counter_desc sq_stats_desc[] = {

drivers/net/ethernet/mellanox/mlx5/core/en_stats.h

+2 −0
Original line number Diff line number Diff line
@@ -106,6 +106,7 @@ struct mlx5e_sw_stats { 
	u64 rx_cache_busy;

	u64 rx_cache_waive;

	u64 rx_congst_umr;

	u64 rx_arfs_err;

	u64 ch_events;

	u64 ch_poll;

	u64 ch_arm;
@@ -202,6 +203,7 @@ struct mlx5e_rq_stats { 
	u64 cache_busy;

	u64 cache_waive;

	u64 congst_umr;

	u64 arfs_err;

};



struct mlx5e_sq_stats {

CRA Git | Maintained and supported by SUSTech CRA and CCSE