Commit 944ed452 authored by Markus Elfring's avatar Markus Elfring Committed by Alexandre Belloni
Browse files

rtc: remove unnecessary error message after platform_get_irq 



The function “platform_get_irq” can log an error already.
Thus omit redundant messages for the exception handling in the
calling functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Link: https://lore.kernel.org/r/04116352-b464-041c-1939-96440133aa6f@web.de


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 8f3d9f35

drivers/rtc/rtc-fsl-ftm-alarm.c

+1 −3
Original line number Diff line number Diff line
@@ -268,10 +268,8 @@ static int ftm_rtc_probe(struct platform_device *pdev) 
	}



	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(&pdev->dev, "can't get irq number\n");

	if (irq < 0)

		return irq;

	}



	ret = devm_request_irq(&pdev->dev, irq, ftm_rtc_alarm_interrupt,

			       IRQF_NO_SUSPEND, dev_name(&pdev->dev), rtc);

drivers/rtc/rtc-lpc24xx.c

+1 −3
Original line number Diff line number Diff line
@@ -205,10 +205,8 @@ static int lpc24xx_rtc_probe(struct platform_device *pdev) 
		return PTR_ERR(rtc->rtc_base);



	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_warn(&pdev->dev, "can't get interrupt resource\n");

	if (irq < 0)

		return irq;

	}



	rtc->clk_rtc = devm_clk_get(&pdev->dev, "rtc");

	if (IS_ERR(rtc->clk_rtc)) {

drivers/rtc/rtc-mt2712.c

+1 −3
Original line number Diff line number Diff line
@@ -328,10 +328,8 @@ static int mt2712_rtc_probe(struct platform_device *pdev) 
	mt2712_rtc_hw_init(mt2712_rtc);



	mt2712_rtc->irq = platform_get_irq(pdev, 0);

	if (mt2712_rtc->irq < 0) {

		dev_err(&pdev->dev, "No IRQ resource\n");

	if (mt2712_rtc->irq < 0)

		return mt2712_rtc->irq;

	}



	platform_set_drvdata(pdev, mt2712_rtc);

CRA Git | Maintained and supported by SUSTech CRA and CCSE