Commit 9435f2bb authored Nov 22, 2019 by Takashi Iwai

ALSA: usb-audio: Fix NULL dereference at parsing BADD



snd_usb_mixer_controls_badd() that parses UAC3 BADD profiles misses a
NULL check for the given interfaces.  When a malformed USB descriptor
is passed, this may lead to an Oops, as spotted by syzkaller.
Skip the iteration if the interface doesn't exist for avoiding the
crash.

Fixes: 17156f23 ("ALSA: usb: add UAC3 BADD profiles support")
Reported-by:  <syzbot+a36ab65c6653d7ccdd62@syzkaller.appspotmail.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191122112840.24797-1-tiwai@suse.de


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent ce3cba78

sound/usb/mixer.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -2930,6 +2930,9 @@ static int snd_usb_mixer_controls_badd(struct usb_mixer_interface *mixer,
		continue;

		iface = usb_ifnum_to_if(dev, intf);
		if (!iface)
		continue;

		num = iface->num_altsetting;

		if (num < 2)

Admin message