slimbus: ngd: remove unnecessary check (94312641) · Commits · 戴 / test

SLIM_MSG_CLK_PAUSE_SEQ_FLG is never set in any of the slim core, so performing a check in ngd driver is totally unnecessary. Also this patch fixes warning about mc field overflow reported with CoverityScan. Making clk pause feature optional will be added to slim core in next development cycle. Reported-by:

Colin Ian King <colin.king@canonical.com> Fixes: ("slimbus: ngd: Add qcom SLIMBus NGD driver") Signed-off-by:

Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/slimbus/qcom-ngd-ctrl.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -777,9 +777,6 @@ static int qcom_slim_ngd_xfer_msg(struct slim_controller *sctrl,
		u8 la = txn->la;
		bool usr_msg = false;

		if (txn->mc & SLIM_MSG_CLK_PAUSE_SEQ_FLG)
		return -EPROTONOSUPPORT;

		if (txn->mt == SLIM_MSG_MT_CORE &&
		(txn->mc >= SLIM_MSG_MC_BEGIN_RECONFIGURATION &&
		txn->mc <= SLIM_MSG_MC_RECONFIGURE_NOW))

drivers/slimbus/slimbus.h

+0 −6

Original line number	Diff line number	Diff line
		@@ -61,12 +61,6 @@
		#define SLIM_MSG_MC_NEXT_REMOVE_CHANNEL 0x58
		#define SLIM_MSG_MC_RECONFIGURE_NOW 0x5F

		/*
		* Clock pause flag to indicate that the reconfig message
		* corresponds to clock pause sequence
		*/
		#define SLIM_MSG_CLK_PAUSE_SEQ_FLG (1U << 8)

		/* Clock pause values per SLIMbus spec */
		#define SLIM_CLK_FAST 0
		#define SLIM_CLK_CONST_PHASE 1

Admin message