Commit 941add8e authored by Puranjay Mohan's avatar Puranjay Mohan Committed by Greg Kroah-Hartman
Browse files

Staging: rtl8723bs: hal: Fix comparison to bool in if statements 



Fix following warnings reported by coccicheck:
WARNING: Comparison to bool
by using !x in place of (x == false) and
x in place of (x == true).

Signed-off-by: default avatarPuranjay Mohan <puranjay12@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2f9dcc46

drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c

+2 −2
Original line number Diff line number Diff line
@@ -299,7 +299,7 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(PDM_ODM_T pDM_Odm) 
				READ_NEXT_PAIR(v1, v2, i);

			}



			if (bMatched == false) {

			if (!bMatched) {

				/*  Condition isn't matched.

				*   Discard the following (offset, data) pairs.

				*/
@@ -568,7 +568,7 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(PDM_ODM_T pDM_Odm) 
				READ_NEXT_PAIR(v1, v2, i);

			}



			if (bMatched == false) {

			if (!bMatched) {

				/*  Condition isn't matched.

				*   Discard the following (offset, data) pairs.

				*/

drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c

+1 −1
Original line number Diff line number Diff line
@@ -270,7 +270,7 @@ void ODM_ReadAndConfig_MP_8723B_MAC_REG(PDM_ODM_T pDM_Odm) 
				READ_NEXT_PAIR(v1, v2, i);

			}



			if (bMatched == false) {

			if (!bMatched) {

				/*  Condition isn't matched. Discard the following (offset, data) pairs. */

				while (v1 < 0x40000000 && i < ArrayLen-2)

					READ_NEXT_PAIR(v1, v2, i);

drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c

+1 −1
Original line number Diff line number Diff line
@@ -301,7 +301,7 @@ void ODM_ReadAndConfig_MP_8723B_RadioA(PDM_ODM_T pDM_Odm) 
				READ_NEXT_PAIR(v1, v2, i);

			}



			if (bMatched == false) {

			if (!bMatched) {

				/*  Condition isn't matched.

				*   Discard the following (offset, data) pairs.

				*/

drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c

+3 −3
Original line number Diff line number Diff line
@@ -1292,7 +1292,7 @@ static void _PHY_SaveADDARegisters8723B( 
	struct hal_com_data *pHalData = GET_HAL_DATA(padapter);

	PDM_ODM_T pDM_Odm = &pHalData->odmpriv;



	if (ODM_CheckPowerStatus(padapter) == false)

	if (!ODM_CheckPowerStatus(padapter))

		return;



	ODM_RT_TRACE(pDM_Odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("Save ADDA parameters.\n"));
@@ -1363,7 +1363,7 @@ static void _PHY_PathADDAOn8723B( 
	ODM_RT_TRACE(pDM_Odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("ADDA ON.\n"));



	pathOn = 0x01c00014;

	if (false == is2T) {

	if (!is2T) {

		pathOn = 0x01c00014;

		PHY_SetBBReg(pDM_Odm->Adapter, ADDAReg[0], bMaskDWord, 0x01c00014);

	} else {
@@ -1811,7 +1811,7 @@ void PHY_IQCalibrate_8723B( 
	u32 		StartTime;

	s32			ProgressingTime;



	if (ODM_CheckPowerStatus(padapter) == false)

	if (!ODM_CheckPowerStatus(padapter))

		return;



	if (!(pDM_Odm->SupportAbility & ODM_RF_CALIBRATION))

drivers/staging/rtl8723bs/hal/hal_com.c

+1 −1
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ u8 hal_com_config_channel_plan( 
	if (0xFF == hw_channel_plan)

		AutoLoadFail = true;



	if (false == AutoLoadFail) {

	if (!AutoLoadFail) {

		u8 hw_chnlPlan;



		hw_chnlPlan = hw_channel_plan & (~EEPROM_CHANNEL_PLAN_BY_HW_MASK);

CRA Git | Maintained and supported by SUSTech CRA and CCSE