Commit 94060d22 authored Oct 17, 2016 by Tobias Klauser Committed by Paul E. McKenney Jan 23, 2017

rcu: Remove unused but set variable

Since commit 7ec99de3 ("rcu: Provide exact CPU-online tracking for
RCU"), the variable mask in rcu_init_percpu_data is set but no longer
used. Remove it to fix the following warning when building with 'W=1':

kernel/rcu/tree.c: In function ‘rcu_init_percpu_data’:
kernel/rcu/tree.c:3765:16: warning: variable ‘mask’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

parent 2535db48

kernel/rcu/tree.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -3765,7 +3765,6 @@ static void
		rcu_init_percpu_data(int cpu, struct rcu_state *rsp)
		{
		unsigned long flags;
		unsigned long mask;
		struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
		struct rcu_node *rnp = rcu_get_root(rsp);

		@@ -3788,7 +3787,6 @@ rcu_init_percpu_data(int cpu, struct rcu_state *rsp)
		* of the next grace period.
		*/
		rnp = rdp->mynode;
		mask = rdp->grpmask;
		raw_spin_lock_rcu_node(rnp); /* irqs already disabled. */
		if (!rdp->beenonline)
		WRITE_ONCE(rsp->ncpus, READ_ONCE(rsp->ncpus) + 1);

Admin message