Commit 9402e959 authored Jan 02, 2020 by Mikulas Patocka Committed by Mike Snitzer Jan 07, 2020

dm crypt: fix GFP flags passed to skcipher_request_alloc()



GFP_KERNEL is not supposed to be or'd with GFP_NOFS (the result is
equivalent to GFP_KERNEL). Also, we use GFP_NOIO instead of GFP_NOFS
because we don't want any I/O being submitted in the direct reclaim
path.

Fixes: 39d13a1a ("dm crypt: reuse eboiv skcipher for IV generation")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent 43069040

drivers/md/dm-crypt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -717,7 +717,7 @@ static int crypt_iv_eboiv_gen(struct crypt_config cc, u8 iv,
		struct crypto_wait wait;
		int err;

		req = skcipher_request_alloc(any_tfm(cc), GFP_KERNEL \| GFP_NOFS);
		req = skcipher_request_alloc(any_tfm(cc), GFP_NOIO);
		if (!req)
		return -ENOMEM;

Admin message