mtd: remove MEMSETOOBSEL macro definition (93fad71c) · Commits · 戴 / test

MEMSETOOBSEL is completely unused and useless. Remove the definition. Note: it's probably best not to use this ioctl number in the future for MTD, since that may cause conflicts between old kernels and new user software (or new kernels and old user software). Artem: leave a comment about MEMSETOOBSEL. Signed-off-by:

Brian Norris <computersforpeace@gmail.com> Signed-off-by:

Artem Bityutskiy <artem.bityutskiy@intel.com>

include/mtd/mtd-abi.h

+6 −1

Original line number	Diff line number	Diff line
		@@ -104,6 +104,12 @@ struct otp_info {
		__u32 locked;
		};

		/*
		* Note, the following ioctl existed in the past and was removed:
		* #define MEMSETOOBSEL _IOW('M', 9, struct nand_oobinfo)
		* Try to avoid adding a new ioctl with the same ioctl number.
		*/

		#define MEMGETINFO _IOR('M', 1, struct mtd_info_user)
		#define MEMERASE _IOW('M', 2, struct erase_info_user)
		#define MEMWRITEOOB _IOWR('M', 3, struct mtd_oob_buf)
		@@ -112,7 +118,6 @@ struct otp_info {
		#define MEMUNLOCK _IOW('M', 6, struct erase_info_user)
		#define MEMGETREGIONCOUNT _IOR('M', 7, int)
		#define MEMGETREGIONINFO _IOWR('M', 8, struct region_info_user)
		#define MEMSETOOBSEL _IOW('M', 9, struct nand_oobinfo)
		#define MEMGETOOBSEL _IOR('M', 10, struct nand_oobinfo)
		#define MEMGETBADBLOCK _IOW('M', 11, __kernel_loff_t)
		#define MEMSETBADBLOCK _IOW('M', 12, __kernel_loff_t)

Admin message