Commit 93f56089 authored Mar 09, 2006 by Dave Jones Committed by James Bottomley Mar 12, 2006

[SCSI] fix two leaks in scsi_alloc_sdev failure paths



If the scsi_alloc_queue or the slave_alloc calls in scsi_alloc_device fail,
we forget to release the locally allocated sdev on the failure path.

Coverity #609

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

parent a0b6b6e5

drivers/scsi/scsi_scan.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -251,6 +251,7 @@ static struct scsi_device scsi_alloc_sdev(struct scsi_target starget,
		/* release fn is set up in scsi_sysfs_device_initialise, so
		* have to free and put manually here */
		put_device(&starget->dev);
		kfree(sdev);
		goto out;
		}

Admin message