Commit 93ee37c2 authored by Dave Martin's avatar Dave Martin Committed by Marc Zyngier
Browse files

thread_info: Add update_thread_flag() helpers 



There are a number of bits of code sprinkled around the kernel to
set a thread flag if a certain condition is true, and clear it
otherwise.

To help make those call sites terser and less cumbersome, this
patch adds a new family of thread flag manipulators

	update*_thread_flag([...,] flag, cond)

which do the equivalent of:

	if (cond)
		set*_thread_flag([...,] flag);
	else
		clear*_thread_flag([...,] flag);

Signed-off-by: default avatarDave Martin <Dave.Martin@arm.com>
Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Acked-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Acked-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent d8ad71fa

include/linux/sched.h

+6 −0
Original line number Diff line number Diff line
@@ -1578,6 +1578,12 @@ static inline void clear_tsk_thread_flag(struct task_struct *tsk, int flag) 
	clear_ti_thread_flag(task_thread_info(tsk), flag);

}



static inline void update_tsk_thread_flag(struct task_struct *tsk, int flag,

					  bool value)

{

	update_ti_thread_flag(task_thread_info(tsk), flag, value);

}



static inline int test_and_set_tsk_thread_flag(struct task_struct *tsk, int flag)

{

	return test_and_set_ti_thread_flag(task_thread_info(tsk), flag);

include/linux/thread_info.h

+11 −0
Original line number Diff line number Diff line
@@ -60,6 +60,15 @@ static inline void clear_ti_thread_flag(struct thread_info *ti, int flag) 
	clear_bit(flag, (unsigned long *)&ti->flags);

}



static inline void update_ti_thread_flag(struct thread_info *ti, int flag,

					 bool value)

{

	if (value)

		set_ti_thread_flag(ti, flag);

	else

		clear_ti_thread_flag(ti, flag);

}



static inline int test_and_set_ti_thread_flag(struct thread_info *ti, int flag)

{

	return test_and_set_bit(flag, (unsigned long *)&ti->flags);
@@ -79,6 +88,8 @@ static inline int test_ti_thread_flag(struct thread_info *ti, int flag) 
	set_ti_thread_flag(current_thread_info(), flag)

#define clear_thread_flag(flag) \

	clear_ti_thread_flag(current_thread_info(), flag)

#define update_thread_flag(flag, value) \

	update_ti_thread_flag(current_thread_info(), flag, value)

#define test_and_set_thread_flag(flag) \

	test_and_set_ti_thread_flag(current_thread_info(), flag)

#define test_and_clear_thread_flag(flag) \

CRA Git | Maintained and supported by SUSTech CRA and CCSE