Commit 93e17a44 authored Mar 24, 2020 by Manivannan Sadhasivam Committed by Greg Kroah-Hartman Mar 26, 2020

bus: mhi: core: Initialize bhie field in mhi_cntrl for RDDM capture

The bhie field in mhi_cntrl needs to be initialized to proper register
base in order to make mhi_rddm_prepare() to work. Otherwise,
mhi_rddm_prepare() will cause NULL pointer dereference.

Fixes: 6fdfdd27 ("bus: mhi: core: Add support for downloading RDDM image during panic")
Reported-by: Hemant Kumar <hemantk@codeaurora.org>
Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20200324061050.14845-4-manivannan.sadhasivam@linaro.org

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3316ab2b

drivers/bus/mhi/core/init.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -979,7 +979,8 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
		goto bhie_error;
		}

		memset_io(mhi_cntrl->regs + bhie_off + BHIE_RXVECADDR_LOW_OFFS,
		mhi_cntrl->bhie = mhi_cntrl->regs + bhie_off;
		memset_io(mhi_cntrl->bhie + BHIE_RXVECADDR_LOW_OFFS,
		0, BHIE_RXVECSTATUS_OFFS - BHIE_RXVECADDR_LOW_OFFS +
		4);