staging: wilc1000: change handle_get_mac_address's return type to void (93dc5d55) · Commits · 戴 / test

When handle_get_mac_address is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by:

Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/wilc1000/host_interface.c

+3 −7

Original line number	Diff line number	Diff line
		@@ -398,7 +398,7 @@ static void handle_get_ip_address(struct wilc_vif *vif, u8 idx)
		netdev_err(vif->ndev, "Failed to get IP address\n");
		}

		static s32 handle_get_mac_address(struct wilc_vif *vif,
		static void handle_get_mac_address(struct wilc_vif *vif,
		struct get_mac_addr *get_mac_addr)
		{
		s32 result = 0;
		@@ -412,13 +412,9 @@ static s32 handle_get_mac_address(struct wilc_vif *vif,
		result = wilc_send_config_pkt(vif, GET_CFG, &wid, 1,
		wilc_get_vif_idx(vif));

		if (result) {
		if (result)
		netdev_err(vif->ndev, "Failed to get mac address\n");
		result = -EFAULT;
		}
		complete(&hif_wait_response);

		return result;
		}

		static s32 handle_cfg_param(struct wilc_vif *vif,

Admin message