Commit 93da4023 authored Aug 22, 2019 by Sagi Grimberg

nvme: enable aen regardless of the presence of I/O queues



AENs in general are not related to the presence of I/O queues,
so enable them regardless. Note that the only exception is that
discovery controller will not support any of the requested AENs
and nvme_enable_aen will respect that and return, so it is still
safe to enable regardless.

Note it is safe to enable AENs even before the initial namespace
scanning as we have the scan operation in a workqueue context.

Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

parent 2d352df5

drivers/nvme/host/core.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1200,6 +1200,8 @@ static void nvme_enable_aen(struct nvme_ctrl *ctrl)
		if (status)
		dev_warn(ctrl->device, "Failed to configure AEN (cfg %x)\n",
		supported_aens);

		queue_work(nvme_wq, &ctrl->async_event_work);
		}

		static int nvme_submit_io(struct nvme_ns ns, struct nvme_user_io __user uio)
		@@ -3785,10 +3787,10 @@ void nvme_start_ctrl(struct nvme_ctrl *ctrl)
		if (ctrl->kato)
		nvme_start_keep_alive(ctrl);

		nvme_enable_aen(ctrl);

		if (ctrl->queue_count > 1) {
		nvme_queue_scan(ctrl);
		nvme_enable_aen(ctrl);
		queue_work(nvme_wq, &ctrl->async_event_work);
		nvme_start_queues(ctrl);
		}
		}

Admin message