Commit 93d8daf4 authored Sep 26, 2018 by Yunsheng Lin Committed by David S. Miller Sep 28, 2018

net: hns3: Fix for netdev not up problem when setting mtu



Currently hns3_nic_change_mtu will try to down the netdev before
setting mtu, and it does not up the netdev when the setting fails,
which causes netdev not up problem.

This patch fixes it by not returning when the setting fails.

Fixes: a8e8b7ff ("net: hns3: Add support to change MTU in HNS3 hardware")
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 996ff918

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -1491,12 +1491,10 @@ static int hns3_nic_change_mtu(struct net_device *netdev, int new_mtu)
		}

		ret = h->ae_algo->ops->set_mtu(h, new_mtu);
		if (ret) {
		if (ret)
		netdev_err(netdev, "failed to change MTU in hardware %d\n",
		ret);
		return ret;
		}

		else
		netdev->mtu = new_mtu;

		/* if the netdev was running earlier, bring it up again */

Admin message