Commit 93d7c318 authored Feb 24, 2020 by Dongli Zhang Committed by Jens Axboe Feb 25, 2020

null_blk: remove unused fields in 'nullb_cmd'



'list', 'll_list' and 'csd' are no longer used.

The 'list' is not used since it was introduced by commit f2298c04
("null_blk: multi queue aware block test driver").

The 'll_list' is no longer used since commit 3c395a96 ("null_blk: set a
separate timer for each command").

The 'csd' is no longer used since commit ce2c350b ("null_blk: use
blk_complete_request and blk_mq_complete_request").

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent c780e86d

drivers/block/null_blk.h

+0 −3

Original line number	Diff line number	Diff line
		@@ -14,9 +14,6 @@
		#include <linux/fault-inject.h>

		struct nullb_cmd {
		struct list_head list;
		struct llist_node ll_list;
		struct __call_single_data csd;
		struct request *rq;
		struct bio *bio;
		unsigned int tag;

drivers/block/null_blk_main.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1518,8 +1518,6 @@ static int setup_commands(struct nullb_queue *nq)

		for (i = 0; i < nq->queue_depth; i++) {
		cmd = &nq->cmds[i];
		INIT_LIST_HEAD(&cmd->list);
		cmd->ll_list.next = NULL;
		cmd->tag = -1U;
		}

Admin message