Commit 93d0c1ab authored Aug 12, 2020 by Sumit Gupta Committed by Rafael J. Wysocki Aug 21, 2020

cpufreq: replace cpu_logical_map() with read_cpuid_mpir()

Commit eaecca9e ("arm64: Fix __cpu_logical_map undefined issue")
fixes the issue with building tegra194 cpufreq driver as module. But
the fix might cause problem while supporting physical CPU hotplug[1].

This patch fixes the original problem by avoiding use of cpu_logical_map().
Instead calling read_cpuid_mpidr() to get MPIDR on target CPU.

[1] https://lore.kernel.org/linux-arm-kernel/20200724131059.GB6521@bogus/



Fixes: df320f89 ("cpufreq: Add Tegra194 cpufreq driver")
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
[ rjw: Subject & changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 9123e3a7

drivers/cpufreq/tegra194-cpufreq.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -56,9 +56,11 @@ struct read_counters_work {

		static struct workqueue_struct *read_counters_wq;

		static enum cluster get_cpu_cluster(u8 cpu)
		static void get_cpu_cluster(void *cluster)
		{
		return MPIDR_AFFINITY_LEVEL(cpu_logical_map(cpu), 1);
		u64 mpidr = read_cpuid_mpidr() & MPIDR_HWID_BITMASK;

		((uint32_t )cluster) = MPIDR_AFFINITY_LEVEL(mpidr, 1);
		}

		/*
		@@ -186,8 +188,10 @@ static unsigned int tegra194_get_speed(u32 cpu)
		static int tegra194_cpufreq_init(struct cpufreq_policy *policy)
		{
		struct tegra194_cpufreq_data *data = cpufreq_get_driver_data();
		int cl = get_cpu_cluster(policy->cpu);
		u32 cpu;
		u32 cl;

		smp_call_function_single(policy->cpu, get_cpu_cluster, &cl, true);

		if (cl >= data->num_clusters)
		return -EINVAL;

Admin message