Commit 93c59907 authored by Veaceslav Falico's avatar Veaceslav Falico Committed by Linus Torvalds
Browse files

copy_signal() cleanup: clean thread_group_cputime_init() 



Remove unneeded initializations in thread_group_cputime_init() and in
posix_cpu_timers_init_group().  They are useless after kmem_cache_zalloc()
was used in copy_signal().

Signed-off-by: default avatarVeaceslav Falico <vfalico@redhat.com>
Acked-by: default avatarOleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 4dd66e69

include/linux/sched.h

+0 −2
Original line number Diff line number Diff line
@@ -2391,9 +2391,7 @@ void thread_group_cputimer(struct task_struct *tsk, struct task_cputime *times); 


static inline void thread_group_cputime_init(struct signal_struct *sig)

{

	sig->cputimer.cputime = INIT_CPUTIME;

	spin_lock_init(&sig->cputimer.lock);

	sig->cputimer.running = 0;

}



static inline void thread_group_cputime_free(struct signal_struct *sig)

kernel/fork.c

+0 −11
Original line number Diff line number Diff line
@@ -833,17 +833,6 @@ static void posix_cpu_timers_init_group(struct signal_struct *sig) 
	/* Thread group counters. */

	thread_group_cputime_init(sig);



	/* Expiration times and increments. */

	sig->it[CPUCLOCK_PROF].expires = cputime_zero;

	sig->it[CPUCLOCK_PROF].incr = cputime_zero;

	sig->it[CPUCLOCK_VIRT].expires = cputime_zero;

	sig->it[CPUCLOCK_VIRT].incr = cputime_zero;



	/* Cached expiration times. */

	sig->cputime_expires.prof_exp = cputime_zero;

	sig->cputime_expires.virt_exp = cputime_zero;

	sig->cputime_expires.sched_exp = 0;



	cpu_limit = ACCESS_ONCE(sig->rlim[RLIMIT_CPU].rlim_cur);

	if (cpu_limit != RLIM_INFINITY) {

		sig->cputime_expires.prof_exp = secs_to_cputime(cpu_limit);

CRA Git | Maintained and supported by SUSTech CRA and CCSE