Unverified Commit 93c02106 authored Oct 30, 2020 by Clément Péron Committed by Mark Brown Oct 30, 2020

ASoC: sun4i-i2s: Fix lrck_period computation for I2S justified mode



Left and Right justified mode are computed using the same formula
as DSP_A and DSP_B mode.
Which is wrong and the user manual explicitly says:

LRCK_PERDIOD:
PCM Mode: Number of BCLKs within (Left + Right) channel width.
I2S/Left-Justified/Right-Justified Mode: Number of BCLKs within each
individual channel width(Left or Right)

Fix this by using the same formula as the I2S mode.

Fixes: 7ae7834e ("ASoC: sun4i-i2s: Add support for DSP formats")
Signed-off-by: Clément Péron <peron.clem@gmail.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20201030144648.397824-2-peron.clem@gmail.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent ec6869b0

sound/soc/sunxi/sun4i-i2s.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -450,11 +450,11 @@ static int sun8i_i2s_set_chan_cfg(const struct sun4i_i2s *i2s,
		switch (i2s->format & SND_SOC_DAIFMT_FORMAT_MASK) {
		case SND_SOC_DAIFMT_DSP_A:
		case SND_SOC_DAIFMT_DSP_B:
		case SND_SOC_DAIFMT_LEFT_J:
		case SND_SOC_DAIFMT_RIGHT_J:
		lrck_period = params_physical_width(params) * slots;
		break;

		case SND_SOC_DAIFMT_LEFT_J:
		case SND_SOC_DAIFMT_RIGHT_J:
		case SND_SOC_DAIFMT_I2S:
		lrck_period = params_physical_width(params);
		break;

Admin message