Commit 93bdc0eb authored Dec 10, 2019 by Gustavo A. R. Silva Committed by Marc Kleine-Budde Jan 02, 2020

can: tcan4x5x: tcan4x5x_parse_config(): fix inconsistent IS_ERR and PTR_ERR



Fix inconsistent IS_ERR and PTR_ERR in tcan4x5x_parse_config().

The proper pointer to be passed as argument is tcan4x5x->device_wake_gpio.

This bug was detected with the help of Coccinelle.

Fixes: 2de49735 ("can: tcan45x: Make wake-up GPIO an optional GPIO")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 5a1f8f5e

drivers/net/can/m_can/tcan4x5x.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -387,7 +387,7 @@ static int tcan4x5x_parse_config(struct m_can_classdev *cdev)
		tcan4x5x->device_wake_gpio = devm_gpiod_get(cdev->dev, "device-wake",
		GPIOD_OUT_HIGH);
		if (IS_ERR(tcan4x5x->device_wake_gpio)) {
		if (PTR_ERR(tcan4x5x->power) == -EPROBE_DEFER)
		if (PTR_ERR(tcan4x5x->device_wake_gpio) == -EPROBE_DEFER)
		return -EPROBE_DEFER;

		tcan4x5x_disable_wake(cdev);

Admin message