Commit 93ae6534 authored Apr 08, 2011 by Michael Chan Committed by David S. Miller Apr 08, 2011

cnic: Fix rtnl deadlock



When cnic_stop_hw() -> cnic_cm_stop_bnx2x_hw() is called under rtnl_lock()
from NETDEV_DOWN event, it waits for cnic_delete_task() to complete.
It will deadlock when cnic_delete_task() takes rtnl_lock() before
calling cnic_ulp_stop_one().

We fix it by removing the rtnl_lock() in cnic_delete_task().
cnic_ulp_stop_one() has mutex and atomic bit ops to prevent important
operations from being done more than once, so it is not necessary to take
rtnl_lock().

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 782d640a

drivers/net/cnic.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -3983,9 +3983,7 @@ static void cnic_delete_task(struct work_struct *work)
		if (test_and_clear_bit(CNIC_LCL_FL_STOP_ISCSI, &cp->cnic_local_flags)) {
		struct drv_ctl_info info;

		rtnl_lock();
		cnic_ulp_stop_one(cp, CNIC_ULP_ISCSI);
		rtnl_unlock();

		info.cmd = DRV_CTL_ISCSI_STOPPED_CMD;
		cp->ethdev->drv_ctl(dev->netdev, &info);

Admin message